forked from ndvbd/Gefen
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix post-merge DCP resharding review findings + harden the flaky handoff test #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
93fda44
Fix DCP resharding review findings: bounded save transient, honest re…
thad0ctor be25ef1
Make the DCP handoff workers report failures instead of a bare assert…
thad0ctor a6bcede
Synchronize rank-local DCP validation; correct the re-blocking regimes
thad0ctor 50375f2
Bound the DCP save's peak memory to one slot's dense form
thad0ctor 8d992b9
Scope the DCP async_save claim to where torch's staging actually copies
thad0ctor f4913ed
Reject positional collision names and overflowing hyper destinations
thad0ctor de473cc
Synchronize the DCP save's rank-local validation; pin name provenance
thad0ctor 0440664
Support async_save with a staging writer that keeps the save bounded
thad0ctor b7a160a
Hold the DCP save's one-slot bound under a multi-threaded writer
thad0ctor 921c310
Page-lock one slot at a time on the bounded DCP save path
thad0ctor e5d736a
Scope the planner-omission and host-memory claims precisely
thad0ctor 3bc6495
Hold the DCP save's fail-before-write and one-slot page-locked bounds
thad0ctor c78aba5
Await the async save through the version-tolerant response
thad0ctor 85c9d9f
Await the async response everywhere, and share the drain's reap budget
thad0ctor b635f6e
Reject block state that straddles devices before the save writes
thad0ctor 9632e3d
Reject one name shared by two parameters before the save
thad0ctor 35e75d7
Condense the DCP adapter's comments and docstrings
thad0ctor 5056c75
Pin the async and unplanned save memory bounds
thad0ctor 9de5c18
Import fully_shard tolerantly across the torch 2.5 floor (#92)
thad0ctor 1564bad
Fix two DCP resharding fail-atomic/sync gaps from PR #90 review
thad0ctor 4f1d721
Cover the reshard levers left implicit: 2->1, CPU-offload, mixed prec…
thad0ctor bb0edcd
Run the whole of _validate_layout inside the DCP sync region
thad0ctor cef24d3
Harden DCP spawn drains; defer world>1 construct-time validation; bou…
thad0ctor c5e3121
Revert the ineffective across-saves pinned bound
thad0ctor 4509add
Reject a float hyperparameter that underflows the destination to zero
thad0ctor 05aacc5
Reject beta round-to-one, non-finite save state, and cross-rank layou…
thad0ctor 39c0054
State the torch 2.5 fully_shard import in the resharding example
thad0ctor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.