fix(prettyDOM): call filterNode with node only - #1383
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2daee5e:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Wrap the
filterNodecallback passed toArray.prototype.filtersoprettyDOMinvokes it with only the child node argument.Why
Array.prototype.filter(filterNode)also passes the item index and source array. That makes the runtime callback contract differ from the documented/typedfilterNode(node)API and can break callbacks that validate their argument list.Fixes #1360
Validation
npm test -- --runTestsByPath src/__tests__/pretty-dom.js --runInBand --watch=falseI also ran the pre-commit lint-staged path; formatting, lint, and related tests passed. The full local
validatestep is currently blocked in this checkout by@types/node/ffi.d.tssyntax errors from a Node/TypeScript version mismatch, before this PR's code is involved.