-
Notifications
You must be signed in to change notification settings - Fork 0
feat(sandbox): migrate harness sandbox support to sbx #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Migrate sandbox integration to sbx | ||
|
|
||
| The harness will hard-cut over from the deprecated `docker sandbox` subcommand to Docker's standalone `sbx` CLI for managing the **Test Sandbox**. We will rename `@testdouble/docker-integration` to `@testdouble/sandbox-integration` and `DockerError` to `SandboxError` at the same time, while keeping user-facing harness commands such as `sandbox-setup`, `shell`, and `clean` stable. We are not keeping a `docker sandbox` fallback because sandbox management is centralized behind a small package API, dual command support would add stale branching, and first-time setup should teach the current Test Sandboxes workflow (`sbx login` then `./harness sandbox-setup`). The integration layer will also convert common `sbx` failures into tailored harness errors for missing CLI, auth/readiness failure, and missing named sandbox. | ||
|
|
||
| ## Considered Options | ||
|
|
||
| - **Hard cutover to `sbx`** — simpler implementation, current upstream command surface, no stale compatibility path. | ||
| - **Compatibility adapter** — lower short-term risk for users with the old CLI, but adds branching around a retired command and keeps outdated terminology in the codebase. | ||
|
|
||
| ## Consequences | ||
|
|
||
| - Developers must install and authenticate `sbx` before running the harness sandbox setup. | ||
| - The integration package name now describes the harness boundary rather than the retired Docker CLI shape. | ||
| - Existing harness command names remain stable for users and scripts. | ||
| - Missing `sbx` installation or authentication failures produce explicit harness errors instead of raw process failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.