Run after_server_start hooks once, after the server responds - #192
Merged
Merged
Conversation
The hooks ran inside the loop that polls for the server to respond, so they ran once per 0.1 seconds the boot took rather than once per boot, each time before the server was known to be responding, and not at all if it responded on the first check. Running them after the loop instead also keeps a slow hook from counting against the 60-second boot timeout. They stay inside the `unless responsive?` guard, so booting an already-booted server doesn't run them again. Server now takes its initializer hooks and its Puma as arguments, so the tests can delay a real server's start without monkeypatching Server::Puma for the whole process. Fixes #186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hooks ran inside the loop that polls for the server to respond, so they ran once per 0.1 seconds the boot took rather than once per boot, each time before the server was known to be responding, and not at all if it responded on the first check.
Running them after the loop instead also keeps a slow hook from counting against the 60-second boot timeout. They stay inside the
unless responsive?guard, so booting an already-booted server doesn't run them again.Server now takes its initializer hooks and its Puma as arguments, so the tests can delay a real server's start without monkeypatching Server::Puma for the whole process.
Fixes #186