fix: require test-kitchen 3.0 or newer - #492
Merged
Merged
Conversation
The floor was `>= 1.0.0`, which has not been true for a long time. This gem already declares `required_ruby_version >= 3.1`, and Test Kitchen 1.x and 2.x are both end of life; nothing tests them, and CI has never run against anything below 4. Raising the floor to 3.0 says what is actually supported rather than letting bundler resolve a pairing nobody has run. The `< 5.0` ceiling is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency floor was
>= 1.0.0:That has not been true for a long time. The gem already declares
required_ruby_version >= 3.1, Test Kitchen 1.x and 2.x are both end of life, and CI has never run against anything below 4. Bundler was free to resolve a pairing nobody has ever run.The
< 5.0ceiling is unchanged.rake styleclean;rspec313 examples, 0 failures;bundle checksatisfied.One thing worth knowing before this merges. I tested the gem against real Test Kitchen 1.25.0 / 2.12.0 / 3.0.0 / 3.9.1 bundles, and it does not currently work on Test Kitchen 3 at all:
generate_keyscallsOpenSSL::PKey::RSA#to_blob, which net-ssh adds by reopening the class. The driver requires net-ssh asrequire "net/ssh" unless defined?(Net::SSH)— but Test Kitchen 3'skitchen/ssh.rbcontains:An autoload defines the constant immediately as a placeholder, so
defined?(Net::SSH)is truthy before net-ssh has loaded a line. The guard skips the require, the monkey patch is never applied, and every Linuxkitchen createdies. Test Kitchen 4 droppedkitchen/ssh.rb, which is the only reason this is invisible today.That is a separate one-line fix (drop the guard — the require is for a side effect, not a constant), so I have left it out of this PR. Happy to open it next; this floor bump is still strictly an improvement on
>= 1.0.0either way.