Ignore negative volume components in mass-weighted averaging - #2646
Draft
mgjarrett wants to merge 8 commits into
Draft
Ignore negative volume components in mass-weighted averaging#2646mgjarrett wants to merge 8 commits into
mgjarrett wants to merge 8 commits into
Conversation
john-science
self-requested a review
August 28, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
Change: Ignore any component with negative area when computing a mass-weighted average temperature and composition for a set of components.
Background: When building a representative block in the
CrossSectionGroupManagerfor a cross section type with the optionaverageByComponent: true, it is necessary to compute an average temperature and composition across all blocks in theBlockCollectionfor each component in the representative block. In normal circumstances, a mass-weighted average is used. However, there are some situations where a component can have negative area/volume and thus negative mass. If some components in theBlockCollectionhave positive mass and others have negative mass, the mass-weighted average temperature of the components can be extremely different than a non-weighted average. In some cases, the resulting temperature could be outside the bounds of defined material properties, which could cause a run to crash.SCR Information
Change Type: fixes
One-Sentence Rationale: This addresses a corner case bug that could cause ARMI apps to crash when there are negative-volume components present.
One-line Impact on Requirements: NA
Checklist
docfolder.pyproject.toml.