feat(gitea): add API retry support for Gitea/Forgejo provider - #2933
feat(gitea): add API retry support for Gitea/Forgejo provider#2933infernus01 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
==========================================
+ Coverage 80.66% 80.78% +0.11%
==========================================
Files 164 164
Lines 13910 13918 +8
==========================================
+ Hits 11221 11244 +23
+ Misses 1967 1948 -19
- Partials 722 726 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
can you please check Chmouel's PR about this and add unit tests wherever needed |
theakshaypant
left a comment
There was a problem hiding this comment.
+1 on Zaki's comment, adding a retry_test similar to github and gitlab would be nice.
211ca07 to
435a5d2
Compare
|
/retest |
theakshaypant
left a comment
There was a problem hiding this comment.
Thanks for addressing the earlier comments.
docs/content/docs/api/configmap.md under heading API Retry should also be updated. It currently only lists GitHub and GitLab as platform supporting this feature.
When enable-api-retry is enabled in the PaC configmap, the Gitea/Forgejo provider wraps its HTTP client with a retry transport that handles rate limits (429), rate-limited 403s, and transient 5xx errors on idempotent requests. This brings Gitea/Forgejo to parity with the GitHub and GitLab retry support added in PR tektoncd#2854. Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
435a5d2 to
59a9f4d
Compare
Yeah thanks, added |
|
/retest |
📝 Description of the Change
retryhttppackage providing a provider-agnostic HTTP retrytransport that handles 429, rate-limited 403s, and 5xx on idempotent
methods with jittered exponential backoff
enable-api-retry,api-retry-max-attempts,api-retry-max-wait-seconds) to controlretry behavior
enable-api-retryis enabled, covering all 21 API call sites🔗 Linked GitHub Issue
Extends PR #2854 to cover Gitea/Forgejo. PR #2854 adds retry support
for GitHub and GitLab but does not cover Gitea/Forgejo.
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.