feat: add keygen with seed for all mldsa variants and falcon1024 - #3
Merged
Conversation
mikelodder7
approved these changes
Dec 4, 2025
mikelodder7
pushed a commit
that referenced
this pull request
Dec 4, 2025
* feat: add keygen with seed for all mldsa variants and falcon1024 * fix: formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the following methods:
For Falcon1024
PQCLEAN_FALCON1024_CLEAN_crypto_sign_keypair_with_seedPQCLEAN_FALCON1024_AVX2_crypto_sign_keypair_with_seedPQCLEAN_FALCON1024_AARCH64_crypto_sign_keypair_with_seedFor Falcon1024 padded
PQCLEAN_FALCONPADDED1024_CLEAN_crypto_sign_keypair_with_seedPQCLEAN_FALCONPADDED1024_AVX2_crypto_sign_keypair_with_seedPQCLEAN_FALCONPADDED1024_AARCH64_crypto_sign_keypair_with_seedFor ML-DSA-X (for X = (44, 65, 87):
pqcrystals_ml_dsa_{X}_avx2_keypairThese two signature variants are now able to generate keypairs from a seed using
OQS_SIG_keypair_with_seedorsig->keypair_with_seed.For signatures where it is not supported a keygen from seed, the above operation yields
OQS_STATUS = OQS_ERROR.Tests
Included nore tests in
sig_keypair_with_seed.cfor ml-dsa and falcon1024 variants.Manual run: