Repository navigation
feat(soilId): pull soilIdAlgorithmVersion on userSoilData sync (Section 6) - #1559
Merged
Merged
Conversation
knipec
approved these changes
Sep 17, 2026
johannesparty
force-pushed
the
feat/soil-id-elevation-query
branch
from
September 25, 2026 21:03
75d181d to
4d9daf4
Compare
Adds soilId { soilIdAlgorithmVersion } to the pullUserData query and
threads it onto the returned object so the mobile client can detect a
soil-ID algorithm change and flush its cached matches. Bumps the
terraso-backend pin to the branch exposing the field. GraphQL types are
gitignored and regenerate on build (npm run generate-types).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ation/
Follows terraso-backend's parallel move of the GraphQL surface from
soilId.elevation to lookup.elevation. fetchElevation was never a
soil-ID concept — it just happened to live under that GraphQL
namespace on the backend. Now:
- src/elevation/elevationService.ts (new) — exports fetchElevation,
wraps the new lookup.elevation query.
- src/soilId/soilIdService.ts — drops the fetchElevation export.
- Bump terraso-backend pin to 58667ca (the "move to lookup namespace"
commit on the algorithm-version stack tip).
Import path change for consumers:
terraso-client-shared/soilId/soilIdService →
terraso-client-shared/elevation/elevationService
Mobile client gets the corresponding import bump in its own PR.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The root soilId field is non-null, so the optional chain was dead; and soilIdAlgorithmVersion is now non-null in the schema, so the `?? undefined` normalization is no longer needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Points at the backend commit that makes soilIdAlgorithmVersion non-null, so codegen now generates `string` (not `string | null`) for the field, matching the syncService cleanup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Converts the stacked in-flight backend commit pin to the released backend tag 2026-09-25.0 (commit f73b1cde), which carries the full soil-id schema (soilId.elevation, soilIdExplanation, soilIdAlgorithmVersion, lookup namespace). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johannesparty
force-pushed
the
feat/soil-id-algorithm-version
branch
from
September 25, 2026 21:09
2317a14 to
412940c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 6 — client-shared link. Threads the backend's
soilIdAlgorithmVersionthrough the pull so the mobile client can detect a soil-ID algorithm change. Stacked on #1558.What
soilId { soilIdAlgorithmVersion }to theuserSoilData(pullUserData) query and thread it onto the returned object.Notes
npm install && npm run generate-types(the schema comes fromnode_modules/terraso-backend).package-lock.jsonreconciles on install.🤖 Generated with Claude Code