Repository navigation
chore(deps): bump taiko-geth revision - #59
Merged
Merged
Conversation
cursor
Bot
dismissed
their stale review
September 22, 2026 03:50
Dismissed the prior approval: Cursor Bugbot is still pending after the wait window, so this head no longer meets the approval criteria. Human review is needed; reviewers were not assigned because two are already requested.
davidtaikocha
approved these changes
Sep 22, 2026
davidtaikocha
left a comment
Member
There was a problem hiding this comment.
Approving. I reviewed the taiko-geth changes and how gaiko2 uses them.
What the bump pulls in (compared with main's 8f5abc6d0636)
- Four taiko-geth PRs: #591, #577 (release 2.6.0), #598 and #601.
4e001283f488is the current tip oftaikoand builds directly on the old pin.- taiko-geth's
go.modis byte-identical, so no other dependencies change. - The
go.sumhash matches sum.golang.org.
Effect on gaiko2
- Of the changed packages, gaiko2 only links
params,coreandcore/taiko_genesis, test binaries included. Their only change is the Masaya removal. gaiko2 references none of it, and chain 167011 is still rejected bychainConfigFor. - #591 and #601 land in
consensus/taikoandminer, which gaiko2 does not link. gaiko2 already enforces the same rules itself:- Shasta
extraDatamust be exactly 7 bytes; - Unzen
parentBeaconRootmust be present and zero; - EIP-4788 then EIP-2935 run before transactions.
- Shasta
- A throwaway side-by-side test with the 4788/2935 contracts deployed matched taiko-geth import under both pins.
- The tx-error classifier and zk-gas schedule that gaiko2 copies from taiko-geth are unchanged upstream.
Verified locally at 15b9e58: go mod verify, go mod tidy -diff, gofmt, build, vet, go test ./... and the race subset all pass.
Non-blocking notes
- PR description wording. It says gaiko2 "consumes" #591 and #601, but gaiko2 doesn't link those packages; its own existing checks provide the same protection. "The only delta is #601" is true relative to this PR's first commit; compared with main it is the four PRs above.
- No Unzen replay test. No checked-in test executes an Unzen block:
processUnzenReplayBlockhas 0% coverage and the mainnet fixture predates Unzen. So CI can't catch an Unzen execution change from a future bump. Mainnet has been on Unzen since 2026-08-06, so a post-Unzen fixture can be captured now. - Untagged pin. The pin is v2.6.0 plus #598 and #601, and has no tag. Worth re-pinning to the v2.7.0 release commit once taikoxyz/taiko-geth#599 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
taikobranch merge commit4e001283f48841068c28fd5335dd784d4ed96bcaextraDatavalidation, Masaya removal, and merged EIP-4788 sealing/import consistency fix from taiko-geth #601Compatibility
v1.18.1-0.20260922032335-4e001283f488fe4f45c83f7apin is merged PR #601extraData, requires an Unzen parent beacon root to be present and zero, and executes the EIP-4788 system call before transaction replay; no Gaiko2 source migration is requiredVerification
go list -m -json github.com/ethereum/go-ethereumgo mod verifygo mod tidy -diffgo test ./...go test -race ./...go vet ./...go build ./...git diff --check origin/mainIndependent review and behavioral verification found no material compatibility or module-provenance issue.