Repository navigation
ci: quote GITHUB_ENV in E2E image build steps (SC2086) - #6
Merged
Merged
Conversation
davidtaikocha
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ci.ymlruns actionlint, which runs shellcheck onrun:scripts only whenshellcheckis installed. The self-hosted runner image has no shellcheck, so these checks were skipped silently. GitHub-hosted runners ship it, and on the hosted-runner benchmark (#5)e2e-harnessfails with:What changes
Quote
$GITHUB_ENVin the image-build step of both E2E workflows. No behaviour change.Test plan
actionlint -config-file .github/actionlint.yamlwith shellcheck installed passes locally.e2e-harnesspasses in CI.