Run simplefs virtio block validation on macOS - #758
Merged
Conversation
simplefs rel2026.0 reworks mkfs.simplefs to build the disk image via the native macOS disk utility, lifting the earlier Linux-only restriction. Enable the simplefs image on macOS and drop the Linux-only guards. Bump simplefs to rel2026.0 in mk/external.mk as well, so the kernel module built from source matches the mkfs that creates the image. Close sysprog21#750
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
Thank @hsule for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplefs rel2026.0 reworks mkfs.simplefs to build the disk image via the native macOS disk utility, lifting the earlier Linux-only restriction. Enable the simplefs image on macOS and drop the Linux-only guards.
Bump simplefs to rel2026.0 in mk/external.mk as well, so the kernel module built from source matches the mkfs that creates the image.
Close #750
Summary by cubic
Enable
simplefsvirtio-block validation on macOS by generating thesimplefsdisk with the native macOS disk utility and removing Linux-only guards. Bumpssimplefstorel2026.0so the kernel module matches the image builder. Closes #750.New Features
simplefsVBLK tests on macOS; always includebuild/disk_simplefs.img.e2fsprogs, createsimplefsimage viamkfs.simplefs(macOS disk utility), attach/detach withhdiutil, and passBLK_DEV_SIMPLEFSfor cleanup.Dependencies
SIMPLEFS_VERSIONtorel2026.0and refresh SHA inmk/external.mk; CI clonesrel2026.0.Written for commit a2a77ce. Summary will update on new commits.