feat: open pubky auth links - #722
Open
ovitrif wants to merge 10 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 2, 2026
ben-kaufman
reviewed
Sep 2, 2026
ben-kaufman
reviewed
Sep 2, 2026
ovitrif
force-pushed
the
codex/715-pubkyauth-links
branch
from
September 2, 2026 21:43
d8110c0 to
48b2191
Compare
ben-kaufman
reviewed
Sep 2, 2026
ovitrif
force-pushed
the
codex/715-pubkyauth-links
branch
from
September 3, 2026 21:51
48b2191 to
c108dee
Compare
ben-kaufman
reviewed
Sep 3, 2026
ben-kaufman
reviewed
Sep 3, 2026
| if isBolt11Invoice(url) { | ||
| return false | ||
| } | ||
| return !PubkyAuthRequest.isProtocolURL(url.absoluteString) |
Contributor
There was a problem hiding this comment.
This catch-all still keeps bitkit://gift-<code>-<amount> links pending until LDK is running. BitkitCore decodes that registered deep-link format into .gift, and GiftLoading already waits for the node and shows its failure UI. On an offline launch or node-start error, the new path gives no gift sheet or error and may delay a limited gift claim indefinitely. Could we release the Bitkit gift namespace after the startup/PIN gates and add an offline routing case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #715
This PR lets iOS receive uniquely targetable Pubky marketplace setup links and route them into the existing explicit watch-only account consent flow.
Description
bitkit://pubky-auth/setup?<original query>through Bitkit's existing iOS URL scheme without competing with Pubky Ring forpubkyauth.pubkyauthrequests for QR scanning and clipboard paste.pubkyringscheme.Linked Issues/Tasks
Preview
QA Notes
Manual Tests
bitkit://pubky-auth/setuplink from a browser or external app, then finish startup/unlock: watch-only consent opens with Cancel and Approve actions.bitkit://pubky-auth/setuplink with an unsupported Bitkit claim: invalid-request toast appears and watch-only consent stays closed.regression:Scanner → Paste QR Code with the valid setup link: watch-only consent opens.regression:Scanner → scan or select a QR image containing the valid setup link: watch-only consent opens.Automated Checks
PubkyAuthURLSchemeTests,PubkyAuthRequestTests,PubkyRingDeepLinkTests,PubkyAuthPermissionTests).MainNavViewone-line if-expression rule was excluded.%23remains data while literal fragments are rejected.PubkyAuthWatchOnlyConsent; raw protocol scanning remains supported.com.apple.Vision Code=9(Could not create inference context); device scan remains manual test 5.Coordination
d8110c042cb4c9002e7fecda9beb8d2a8cd87d67.