Skip to content

Update RedirectToPreferredLocaleSubscriber.php - #1569

Open
flovntp wants to merge 1 commit into
symfony:mainfrom
flovntp:patch-2
Open

Update RedirectToPreferredLocaleSubscriber.php#1569
flovntp wants to merge 1 commit into
symfony:mainfrom
flovntp:patch-2

Conversation

@flovntp

@flovntp flovntp commented May 13, 2025

Copy link
Copy Markdown
Contributor

It needs to be an array for this eventListener to be triggered
(just get the case where this eventListener is not triggered because of that)

It needs to be an array for this eventListener to be triggered
@94noni

94noni commented May 15, 2025

Copy link
Copy Markdown
Contributor

are you sure its not because of another event prior to this one that redirects or stoped the flow?
because its legit to have event => method as well as what you propose as far as I know

@stof

stof commented May 15, 2025

Copy link
Copy Markdown
Member

To me, the description of the change is what causes confusion in the discussion. The actual change being done here is changing the priority of the listener. Saying "it must be an array" does not describe what is done (indeed, to use a non-0 priority, it needs to be an array, but you could make it an array without changing the priority, so using an array is not the meaningful change).

and then, what needs to be explained is why the priority needs to be so high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants