Update RedirectToPreferredLocaleSubscriber.php - #1569
Open
flovntp wants to merge 1 commit into
Open
Conversation
It needs to be an array for this eventListener to be triggered
Contributor
|
are you sure its not because of another event prior to this one that redirects or stoped the flow? |
Member
|
To me, the description of the change is what causes confusion in the discussion. The actual change being done here is changing the priority of the listener. Saying "it must be an array" does not describe what is done (indeed, to use a non-0 priority, it needs to be an array, but you could make it an array without changing the priority, so using an array is not the meaningful change). and then, what needs to be explained is why the priority needs to be so high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It needs to be an array for this eventListener to be triggered
(just get the case where this eventListener is not triggered because of that)