[llvm][AArch64] Avoid iterating off the beginning of a BB in a backwa… - #13970
Merged
Conversation
…rd scan (llvm#217752) ... using a reversed range, rather than raw iterator comparisons, which got us in trouble previously in a block that was entirely made up of FrameDestroy instructions. rdar://185425744 (cherry picked from commit ab0b549) I am leaving out the test because we need this fix ASAP, and I am not sure how to correctly adjust the test to pass on this branch. The author of the original commit promised to follow up on that.
|
LGTM. I'll pick the test shortly. |
jroelofs
reviewed
Aug 21, 2026
| // outside the red-zone. | ||
| SmallVector<MachineInstr *, 2> SPMods; | ||
| if (ArgumentStackToRestore > 0) { | ||
| for (auto I = MBBI; I->getFlag(MachineInstr::FrameDestroy); --I) { |
There was a problem hiding this comment.
We lost the FrameDestroy check here. Adding it back, along with the test in #13975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rd scan (llvm#217752)
... using a reversed range, rather than raw iterator comparisons, which got us in trouble previously in a block that was entirely made up of FrameDestroy instructions.
rdar://185425744
(cherry picked from commit ab0b549)
I am leaving out the test because we need this fix ASAP, and I am not sure how to correctly adjust the test to pass on this branch. The author of the original commit promised to follow up on that.