Repository navigation
Repair module aliasing, and stabilize socket on CI - #247
Merged
Merged
Conversation
Apply the proposed fix from swhitty#243 (49356ee) for Linux CI verification.
Apply the proposed fix from swhitty#244 (f38b812) for Linux CI verification.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 93.72% 93.74% +0.01%
==========================================
Files 72 72
Lines 3777 3787 +10
==========================================
+ Hits 3540 3550 +10
Misses 237 237 ☔ View full report in Codecov by Harness. |
tonyarnold
marked this pull request as ready for review
October 3, 2026 11:22
swhitty
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftPM loses a dependent module alias, UDP sends can use invalid source addresses, and reused socket descriptors can lose readiness notifications. Cancellation tests also fail when task startup exceeds their fixed sleeps.
CSystemLinuxdependency.Includes Luke Howard's fixes from #243 and #244 so that I can test if this is all passing on CI.