Match CSS attribute selector values before retaining attributes - #2248
Open
Neallin-917 wants to merge 1 commit into
Open
Match CSS attribute selector values before retaining attributes#2248Neallin-917 wants to merge 1 commit into
Neallin-917 wants to merge 1 commit into
Conversation
Neallin-917
marked this pull request as ready for review
August 13, 2026 02:43
Neallin-917
force-pushed
the
neallin-917-fix-2145-attr-selector-match
branch
from
August 14, 2026 13:46
7f6744a to
2523117
Compare
Author
|
Friendly follow-up: this is a focused fix for CSS attribute-selector values being matched before attributes are retained, with a regression fixture covering quoted and escaped values. It was validated with the project's QA suite. I would appreciate a maintainer review when convenient, and I am happy to adjust the approach if needed. Thank you. |
Neallin-917
force-pushed
the
neallin-917-fix-2145-attr-selector-match
branch
from
August 30, 2026 02:05
2523117 to
c58705b
Compare
Author
|
I rebased this focused change onto current main after confirming the earlier CI failure came from the prior base’s regression-test dependency state, outside this PR’s diff. Local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2145
includesAttrSelectornow evaluates CSS attribute selector operators against the current attribute value. The callers ininlineStylesandremoveUnknownsAndDefaultsnow provide that value, so selectors that cannot match no longer keep a redundant attribute.Added unit coverage for supported operators and regressions for both affected plugins.
Validation:
tsd, and bundle buildAI assistance: this patch was AI-assisted and the listed validations were run locally.