fix(cleanupIds): don't skip IDs that were already reassigned - #2238
Open
victorvianna wants to merge 1 commit into
Open
fix(cleanupIds): don't skip IDs that were already reassigned#2238victorvianna wants to merge 1 commit into
victorvianna wants to merge 1 commit into
Conversation
The generator skips a candidate ID when it looks like a dangling external reference (svg#1815). Renaming an element deletes its old ID from nodeById, so IDs already reassigned during the pass matched that test too and were skipped, yielding non-consecutive IDs that changed again on a second pass. Collect external references before any renaming, and guard separately against unreferenced IDs, which are kept when remove is disabled and otherwise led to duplicate IDs and references resolving to the wrong element. Fixes svg#2237
Author
|
@SethFalco PTAL |
Author
|
@TrySound Could you please approve the workflow runs when you have a chance? Happy to address any feedback. |
Author
|
Thanks. The failure is unrelated to the CL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator skips a candidate ID when it looks like a dangling external reference (#1815). Renaming an element deletes its old ID from nodeById, so IDs already reassigned during the pass matched that test too and were skipped, yielding non-consecutive IDs that changed again on a second pass.
Collect external references before any renaming, and guard separately against unreferenced IDs, which are kept when remove is disabled and otherwise led to duplicate IDs and references resolving to the wrong element.
Fixes #2237