feat(convertShapeToPath): convert rect with rounded corners using arcs - #1816
Open
JoCa96 wants to merge 9 commits into
Open
feat(convertShapeToPath): convert rect with rounded corners using arcs #1816JoCa96 wants to merge 9 commits into
JoCa96 wants to merge 9 commits into
Conversation
Collaborator
|
why would you want to do this? this seems like the opposite of optimization |
Author
That's true for all conversions that are enabled by the The need for this is use-case dependant. |
|
This is basically the opposite of #1748, there are definitely cases where one is closer than the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
rectshape with a definedrxand/orryto path when theconvertArcsparameter is true.E.g.
will become
When
rxandryare invalid or0the conversion will be performed without arcs as there are no rounded corners in that case.