convertShapeToPath: Convert rectangles with radius to paths - #1516
Open
santhoshtr wants to merge 1 commit into
Open
convertShapeToPath: Convert rectangles with radius to paths#1516santhoshtr wants to merge 1 commit into
santhoshtr wants to merge 1 commit into
Conversation
moatorres
reviewed
Oct 18, 2021
| item.attributes.height != null && | ||
| item.attributes.rx == null && | ||
| item.attributes.ry == null | ||
| item.attributes.height != null |
There was a problem hiding this comment.
I guess it should be node.attributes.width instead of item as per 2.7.0
moatorres
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Not sure if you've forked the current version, but this code seems to work if we change item to node as in:
enter: (node, parentNode) => { ...But using let rx = Number( ... actually messes up the code as this variable name is used down the line.
// optionally covert ellipse
if (node.name === 'ellipse' && convertArcs) {
const ecx = Number(node.attributes.cx || '0');
const ecy = Number(node.attributes.cy || '0');
const rx = Number(node.attributes.rx || '0');
const ry = Number(node.attributes.ry || '0');
if (Number.isNaN(ecx - ecy + rx - ry)) {
return;
}Maybe it could be named rry to avoid conflicts? Shooting in the dark here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
rectshapes withrxorryradius attributes are not converted to path by convertShapeToPath plugin.This PR adds support for converting those radius to paths under convertArcs setting of convertShapeToPath plugin.
Reference spec: https://www.w3.org/TR/SVG11/shapes.html#RectElementRXAttribute
Usecase example: When icons are converted to single path using
mergePathswithforce=truesetting icons with at least one rectangle with given radius is left out. This is problematic for single path icons patterns followed by materialicons, or fontawesome and others.