Updated naming convention for ALAJOYWrapper main script: "tendl_to_alarajoy" - #316
Open
eitan-weinstein wants to merge 1 commit into
Open
Updated naming convention for ALAJOYWrapper main script: "tendl_to_alarajoy"#316eitan-weinstein wants to merge 1 commit into
eitan-weinstein wants to merge 1 commit into
Conversation
eitan-weinstein
added this to the
Complete pipeline for the inclusion of new data libraries milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the naming of the main script in ALARAJOYWrapper from
preprocess_fendl3.pytotendl_to_alarajoy.py, and associated references/documentation throughout. This felt necessary to me because ALARAJOYWrapper is now much more expansive both in its capabilities and intended uses beyond strictly FENDL3 compatibility. Of course, this is still our primary motivation for this project, but the naming was no longer representative of the fact that this preprocessor is really a TENDL preprocessor into an ALARAJOY-readable format and that the specific application of preparing TENDL-2017 data according to the FENDL3.2x specifications is only one of many TENDL to ALARAJOY conversions possible.