Single neutron energy vertical line option in xs_plotting - #308
Open
eitan-weinstein wants to merge 2 commits into
Open
Single neutron energy vertical line option in xs_plotting#308eitan-weinstein wants to merge 2 commits into
eitan-weinstein wants to merge 2 commits into
Conversation
gonuke
requested changes
Jul 27, 2026
gonuke
left a comment
gonuke
left a comment
Member
There was a problem hiding this comment.
Thanks @eitan-weinstein - Some cleanup suggestions
Comment on lines
+144
to
+161
| if KZA == dsv_pKZA and MT == flagged_num_to_int(dsv_MT)[0]: | ||
| if KZA == dsv_pKZA and MT == flagged_num_to_int(dsv_MT): |
Member
There was a problem hiding this comment.
I've noticed this in a couple of PRs, was it originally a bug? Is there a PR that just fixes this?
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll make a small PR just for that bug.
gonuke
requested changes
Jul 28, 2026
gonuke
left a comment
gonuke
left a comment
Member
There was a problem hiding this comment.
Ready to merge after a rebase for the other small change
eitan-weinstein
force-pushed
the
neutron_energy_vline
branch
from
July 28, 2026 13:09
5195766 to
264acb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new functionality to
xs_plotting.pyto allow for the plotting of a vertical line at a provided neutron energy to highlight the plot in a specific region. This was motivated by the desire to see the differences in group structure effects for 14.1 MeV neutrons by having a clear marker of where on the plot to focus.