Saving Isomer '*' Flag for flagged_num_to_int() plotting function - #302
Closed
eitan-weinstein wants to merge 1 commit into
Closed
Saving Isomer '*' Flag for flagged_num_to_int() plotting function#302eitan-weinstein wants to merge 1 commit into
flagged_num_to_int() plotting function#302eitan-weinstein wants to merge 1 commit into
Conversation
Member
|
Is this now incorporated into #305? Do we still need this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the function
xs_plotting.flagged_num_to_int()to additionally return a string of all of the'*'isomer flags in the value passed through it. For example, the input'4*'would return two values:(4, '*'). Likewise, an input without any'*'values will return an empty string for theisomer_flagreturn value.The motivation behind this is to be able to retain the distinction between MT values in which there may be present anywhere from 0-2
'*'flags for a given target nuclide. Without this update, all of these distinct reactions would be improperly characterized by only the star-less MT.