Repository navigation
Deterministic plumtree simulator with maintenance tick and selection metrics - #585
Open
wisper-dev wants to merge 2 commits into
Open
wisper-dev wants to merge 2 commits into
wisper-dev wants to merge 2 commits into
Conversation
eager_peers, known_peers and ring_locked were HashSets, so their iteration order, which the seeded peer selection and the sends follow, changed between processes, and the simulator gave different results for the same seed. They are now IndexSets like lazy_peers, and their accessors return &IndexSet. The sim report also breaks ties on send time by message id.
With the new Params::maintenance_interval set, every simulated node runs update_peer_topology every 60 s with a random phase, passing the members it believes alive; existing tests leave it off. Restart scenarios report full rebuilds, overlay churn, PRUNE/GRAFT, eager in-degree over time, where a returning node lands and how soon it gets messages again, and delivery to nodes not restarting around the send. Adds a CI-sized flapper test and three ignored longer runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 for #582. @somtochiama, this is the simulator part we discussed in the issue.
eager_peers,known_peersandring_lockedare nowIndexSet. Their iteration order fed peer selection, so one seed gave different runs (PRUNE 1115 / 1084 / 1090 / 1070, now 1088 every time).peer_downflag. This simulator does not exercise the reconciliation from Reconcile plumtree peers with the members snapshot on the maintenance tick #567.