Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Sources/Functions/FunctionsClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,13 @@ public final class FunctionsClient: Sendable {
_ functionName: String,
options invokeOptions: FunctionInvokeOptions = .init()
) -> AsyncThrowingStream<Data, any Error> {
streamResponse(functionName, options: invokeOptions).stream
}

func streamResponse(
_ functionName: String,
options invokeOptions: FunctionInvokeOptions
) -> (stream: AsyncThrowingStream<Data, any Error>, delegate: StreamResponseDelegate) {
let (stream, continuation) = AsyncThrowingStream<Data, any Error>.makeStream()
let delegate = StreamResponseDelegate(continuation: continuation)

Expand All @@ -284,13 +291,10 @@ public final class FunctionsClient: Sendable {
task.resume()

continuation.onTermination = { _ in
task.cancel()

// Hold a strong reference to delegate until continuation terminates.
_ = delegate
session.invalidateAndCancel()
}

return stream
return (stream, delegate)
}

private func buildRequest(functionName: String, options: FunctionInvokeOptions)
Expand Down
28 changes: 28 additions & 0 deletions Tests/FunctionsTests/FunctionsClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -566,4 +566,32 @@ struct FunctionsClientTests {
} catch FunctionsError.relayError {
}
}

@Test
func invokeWithStreamedResponseInvalidatesSession() async throws {
let sut = makeSUT()

Mock(
url: url.appendingPathComponent("stream"),
statusCode: 200,
data: [.post: Data("hello world".utf8)]
)
.register()

weak var weakDelegate: StreamResponseDelegate?

do {
let (stream, delegate) = sut.streamResponse("stream", options: FunctionInvokeOptions())
weakDelegate = delegate
for try await _ in stream {}
}

// URLSession releases its delegate asynchronously after invalidation.
let deadline = Date().addingTimeInterval(5)
while weakDelegate != nil, Date() < deadline {
try await Task.sleep(nanoseconds: 10_000_000)
}

#expect(weakDelegate == nil, "URLSession was not invalidated; its delegate leaked")
}
}