refactor(storage): adopt swift-openapi-generator for the HTTP layer

Package.swift

@@ -30,6 +30,7 @@ let package = Package(
     .package(url: "https://github.com/pointfreeco/swift-snapshot-testing", from: "1.17.0"),
     .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.2.2"),
     .package(url: "https://github.com/WeTransfer/Mocker", from: "3.0.0"),
+    .package(url: "https://github.com/apple/swift-openapi-runtime", from: "1.6.0"),
   ],
   targets: [
     .target(
@@ -169,6 +170,7 @@ let package = Package(
       dependencies: [
         .product(name: "ConcurrencyExtras", package: "swift-concurrency-extras"),
         .product(name: "HTTPTypes", package: "swift-http-types"),
+        .product(name: "OpenAPIRuntime", package: "swift-openapi-runtime"),
         "Helpers",
       ]
     ),

Sources/Storage/OpenAPI/StorageOpenAPITransport.swift

@@ -0,0 +1,84 @@
+import Foundation
+import HTTPTypes
+import OpenAPIRuntime
+
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
+
+/// Bridges the generated OpenAPI client's HTTP layer onto ``StorageApi``'s shared header-merging
+/// and ``StorageHTTPSession`` pipeline. Unlike the hand-written `execute(_:)` path, this transport
+/// never throws on non-2xx responses — it returns them as-is so the generated client's typed
+/// `Output` cases carry the real status and error body, and callers decode ``StorageError`` from
+/// those cases instead.
+struct StorageOpenAPITransport: ClientTransport {
+  var execute: @Sendable (Helpers.HTTPRequest) async throws -> Helpers.HTTPResponse
+
+  func send(
+    _ request: HTTPTypes.HTTPRequest,
+    body: OpenAPIRuntime.HTTPBody?,
+    baseURL: URL,
+    operationID: String
+  ) async throws -> (HTTPTypes.HTTPResponse, OpenAPIRuntime.HTTPBody?) {
+    let requestTarget = request.path ?? ""
+    let pathAndQuery = requestTarget.split(separator: "?", maxSplits: 1)
+    let path = String(pathAndQuery.first ?? "")
+    let query = pathAndQuery.count > 1 ? String(pathAndQuery[1]) : nil
+
+    guard var components = URLComponents(url: baseURL, resolvingAgainstBaseURL: false) else {
+      throw StorageOpenAPITransportError.invalidBaseURL(baseURL)
+    }
+    components.percentEncodedPath += path
+    components.percentEncodedQuery = query
+
+    guard let url = components.url else {
+      throw StorageOpenAPITransportError.invalidRequestURL(path: requestTarget, baseURL: baseURL)
+    }
+
+    let requestBody: Data?
+    if let body {
+      requestBody = try await Data(collecting: body, upTo: .max)
+    } else {
+      requestBody = nil
+    }
+
+    var headers = HTTPFields()
+    for field in request.headerFields {
+      // ponytail: the generated client always sets an `Accept` header via
+      // `converter.setAcceptHeader`; the hand-written implementations being migrated never sent
+      // one, so drop it here to keep wire behavior byte-identical during the migration.
+      if field.name == .accept { continue }
+      if field.name == .contentType, field.value == "application/json; charset=utf-8" {
+        // ponytail: the generated client always appends `; charset=utf-8` to JSON content types
+        // via `converter.setRequiredRequestBodyAsJSON`; the hand-written implementations being
+        // migrated always sent plain `application/json`, so strip the suffix here to keep wire
+        // behavior byte-identical during the migration.
+        headers[field.name] = "application/json"
+        continue
+      }
+      headers[field.name] = field.value
+    }
+
+    let helpersRequest = Helpers.HTTPRequest(
+      url: url,
+      method: request.method,
+      headers: headers,
+      body: requestBody
+    )
+
+    let response = try await execute(helpersRequest)
+
+    let responseBody: OpenAPIRuntime.HTTPBody? =
+      response.data.isEmpty ? nil : OpenAPIRuntime.HTTPBody(response.data)
+
+    return (
+      HTTPTypes.HTTPResponse(status: .init(code: response.statusCode)),
+      responseBody
+    )
+  }
+}
+
+enum StorageOpenAPITransportError: Error {
+  case invalidBaseURL(URL)
+  case invalidRequestURL(path: String, baseURL: URL)
+}

Sources/Storage/OpenAPI/openapi-generator-config.yaml

@@ -0,0 +1,10 @@
+generate:
+  - types
+  - client
+accessModifier: internal
+filter:
+  operations:
+    - vectorBucketCreate
+    - vectorBucketDelete
+    - vectorBucketGet
+    - vectorBucketList