✨(backend) make forward auth request uri header configurable - #794
Open
erincandescent wants to merge 1 commit into
Open
✨(backend) make forward auth request uri header configurable#794erincandescent wants to merge 1 commit into
erincandescent wants to merge 1 commit into
Conversation
In our deployment we're using Traefik, not nginx, as an ingress. Traefik uses X-Forwarded-Uri instead of X-Original-Uri. This adds a setting which lets users adapt Docs to their ingress proxy of choice Port of suitenumerique/docs#2241 to drive Signed-off-by: Erin Shepherd <erin.shepherd@e43.eu>
|
Author
|
I see there's a similar PR #743 but (a) honestly I don't see a good reason to allow multiple headers (in fact it seems like a security disaster) and (b) I don't see a reason to diverge from docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In our deployment we're using Traefik, not nginx, as an ingress. Traefik uses
X-Forwarded-Urlinstead ofX-Original-Url. This adds a setting which lets users adapt Docs to their ingress proxy of choicePort of suitenumerique/docs#2241 (written by me) from Docs
Proposal
Add a
MEDIA_AUTH_ORIGINAL_URL_HEADERwhich lets you configure it, withHTTP_X_ORIGINAL_URLas default valueAI usage
Porting from the Docs codebase to Drive was done by DeepSeek 4 Flash. The original code was written by me and @lunika , and it appears to have reproduced it faithfully