Skip to content

✨(frontend) add monthly "nth weekday" recurrence option - #70

Open
nicolasaunai wants to merge 3 commits into
suitenumerique:mainfrom
nicolasaunai:feat/monthly-nth-weekday-recurrence
Open

✨(frontend) add monthly "nth weekday" recurrence option#70
nicolasaunai wants to merge 3 commits into
suitenumerique:mainfrom
nicolasaunai:feat/monthly-nth-weekday-recurrence

Conversation

@nicolasaunai

Copy link
Copy Markdown

Purpose

Users could not create an event recurring on e.g. "the 1st Tuesday of
every month" — the monthly recurrence editor only supported "on day N
of the month" (BYMONTHDAY), with no way to express an ordinal
weekday (BYDAY=1TU).

Proposal

  • Add a "day of the week" sub-mode to the monthly recurrence editor,
    alongside the existing "day of month" option, with ordinal (1st /
    2nd / 3rd / 4th / last) + weekday selects.

  • ts-ics already serializes byDay: [{ day, occurrence }] correctly
    to RRULE (BYDAY=1TU, BYDAY=-1FR, ...), so no backend or CalDAV
    changes were needed.

  • Added unit tests for the new helpers and translations (en/fr/nl).

  • make test-front

  • make typecheck-front

  • make lint-front

Add a "day of the week" sub-mode to the monthly recurrence editor, so
events can repeat on e.g. the 1st Tuesday or last Friday of each
month (RRULE BYDAY with an ordinal), alongside the existing "day of
month" option. ts-ics already serializes this correctly, so no
backend or CalDAV changes were needed.

Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@nicolasaunai, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9fbb8d2e-1f29-4c13-89ea-e077652e70e9

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb5200 and 03f9c3b.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • src/frontend/src/features/calendar/components/scheduler/RecurrenceEditor.scss
  • src/frontend/src/features/calendar/components/scheduler/RecurrenceEditor.tsx
  • src/frontend/src/features/calendar/components/scheduler/__tests__/RecurrenceEditor.helpers.test.ts
  • src/frontend/src/features/i18n/translations.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant