✨(frontend) add monthly "nth weekday" recurrence option - #70
✨(frontend) add monthly "nth weekday" recurrence option#70nicolasaunai wants to merge 3 commits into
Conversation
Add a "day of the week" sub-mode to the monthly recurrence editor, so events can repeat on e.g. the 1st Tuesday or last Friday of each month (RRULE BYDAY with an ordinal), alongside the existing "day of month" option. ts-ics already serializes this correctly, so no backend or CalDAV changes were needed. Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
Signed-off-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Users could not create an event recurring on e.g. "the 1st Tuesday of
every month" — the monthly recurrence editor only supported "on day N
of the month" (
BYMONTHDAY), with no way to express an ordinalweekday (
BYDAY=1TU).Proposal
Add a "day of the week" sub-mode to the monthly recurrence editor,
alongside the existing "day of month" option, with ordinal (1st /
2nd / 3rd / 4th / last) + weekday selects.
ts-icsalready serializesbyDay: [{ day, occurrence }]correctlyto RRULE (
BYDAY=1TU,BYDAY=-1FR, ...), so no backend or CalDAVchanges were needed.
Added unit tests for the new helpers and translations (en/fr/nl).
make test-frontmake typecheck-frontmake lint-front