Skip to content

Resolve orphaned incomplete orders superseded by a newer checkout #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimcoleman wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Resolve orphaned incomplete orders superseded by a newer checkout #3715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions includes/checkout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,54 @@ function pmpro_complete_checkout( $order ) {
}
}

/**
* Mark a member's older incomplete orders as error when a newer order supersedes them.
*
* Covers re-checking out for the same level, or switching to another level in a group that only
* allows one level at a time. Incomplete orders tied to a still-active subscription are left alone.
*
* @since TBD
*
* @param int $user_id The ID of the user who completed checkout.
* @param MemberOrder $order The newly completed order.
*/
function pmpro_error_orphaned_incomplete_orders( $user_id, $order ) {
if ( empty( $order->id ) || 'success' !== $order->status || empty( $order->membership_id ) ) {
return;
}

// Switching to a level in a one-at-a-time group deactivates sibling levels, so their orders are superseded too.
$superseded_level_ids = array( $order->membership_id );
$level_group_id = pmpro_get_group_id_for_level( $order->membership_id );
$level_group = empty( $level_group_id ) ? false : pmpro_get_level_group( $level_group_id );
if ( ! empty( $level_group ) && empty( $level_group->allow_multiple_selections ) ) {
$superseded_level_ids = pmpro_get_level_ids_for_group( $level_group->id );
}

$incomplete_orders = MemberOrder::get_orders( array(
'user_id' => $user_id,
'membership_level_id' => $superseded_level_ids,
'status' => array( 'token', 'pending', 'review' ),
) );

foreach ( $incomplete_orders as $incomplete_order ) {
// Only resolve orders older than the one we just completed.
if ( (int) $incomplete_order->id >= (int) $order->id ) {
continue;
}

$subscription = $incomplete_order->get_subscription();
if ( ! empty( $subscription ) && 'active' === $subscription->get_status() ) {
continue;
}

$incomplete_order->add_order_note( __( 'Order marked as error because it was superseded by a newer successful order.', 'paid-memberships-pro' ) );
$incomplete_order->status = 'error';
$incomplete_order->saveOrder();
}
}
add_action( 'pmpro_after_checkout', 'pmpro_error_orphaned_incomplete_orders', 10, 2 );

/**
* Legacy function.
*
Expand Down