Skip to content

Show pending memberships more clearly on the account page #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimcoleman wants to merge 3 commits into
base: dev
Choose a base branch
from
+212 −3
Open

Show pending memberships more clearly on the account page #3714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5372780
Initial work toward showing pending membership more clearly on accoun…
kimcoleman Jun 16, 2026
77192e6
Merge branch 'dev' into account-pending-order-ux
kimcoleman Jun 29, 2026
8b4f946
Don't surface stale pending orders on the account page
kimcoleman Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 129 additions & 0 deletions includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5439,6 +5439,11 @@ function pmpro_check_token_order_for_completion( $order_id ) {
* Show a message on the account page for a specific membership level.
*/
function pmpro_display_member_account_level_message( $level ) {
// Only show the message to users who have this level. Cards may also be shown for memberships that are waiting on payment.
if ( ! pmpro_hasMembershipLevel( $level->id ) ) {
return;
}

$membership_account_message = get_pmpro_membership_level_meta( $level->id, 'membership_account_message', true );
if ( $membership_account_message ) {
?>
Expand All @@ -5450,6 +5455,130 @@ function pmpro_display_member_account_level_message( $level ) {
}
add_action( 'pmpro_membership_account_after_level_card_content', 'pmpro_display_member_account_level_message' );

/**
* Get the live pending order for a user and level.
*
* Only returns the user's most recent order for the level, and only if it is still pending.
* A newer order in any other status (e.g. a 'success' order from paying again by a different
* method) means the pending order is stale and should not be surfaced.
*
* The order is also treated as stale if the user has since started a different level in the same
* single-selection group, since holding one level in that group means they chose another plan.
*
* @since TBD
*
* @param int $user_id The ID of the user to check.
* @param int $level_id The ID of the level to check.
* @return MemberOrder|null The pending order or null if there is none.
*/
function pmpro_get_pending_order_for_user_level( $user_id, $level_id ) {
static $cache = array();

$cache_key = $user_id . ':' . $level_id;
if ( ! array_key_exists( $cache_key, $cache ) ) {
$cache[ $cache_key ] = null;

$recent_orders = MemberOrder::get_orders(
array(
'user_id' => $user_id,
'membership_level_id' => $level_id,
'limit' => 1,
)
);
$recent_order = empty( $recent_orders ) ? null : current( $recent_orders );

// The pending order is only live if it is the user's most recent order for the level.
if ( ! empty( $recent_order ) && $recent_order->status === 'pending' ) {
$cache[ $cache_key ] = $recent_order;

// In a single-selection group, a level the user started after this order supersedes it.
$group = pmpro_get_level_group( pmpro_get_group_id_for_level( $level_id ) );
if ( ! empty( $group ) && empty( $group->allow_multiple_selections ) ) {
$group_level_ids = wp_list_pluck( pmpro_get_levels_for_group( $group->id ), 'id' );
$held_levels = pmpro_getMembershipLevelsForUser( $user_id );
if ( ! empty( $held_levels ) ) {
foreach ( $held_levels as $held_level ) {
// Skip the pending level itself and any level outside this group.
if ( $held_level->id == $level_id || ! in_array( $held_level->id, $group_level_ids ) ) {
continue;
}
// Only supersede if the held level was started after the pending order was created.
if ( $held_level->startdate >= $recent_order->timestamp ) {
$cache[ $cache_key ] = null;
break;
}
}
}
}
}
}

return $cache[ $cache_key ];
}

/**
* Show a message on the level card on the Membership Account page when the user has a pending order for that level.
*
* @since TBD
*
* @param object $level The membership level object for the card being shown.
*/
function pmpro_account_pending_order_message( $level ) {
global $current_user;

// Check for a pending order for this user and level.
$pending_order = pmpro_get_pending_order_for_user_level( $current_user->ID, $level->id );
if ( empty( $pending_order ) ) {
return;
}

// If the user has this level, a renewal payment is past due. Otherwise, the membership is waiting on its first payment.
if ( pmpro_hasMembershipLevel( $level->id, $current_user->ID ) ) {
$message = __( 'Your latest payment for this membership is past due. We are waiting for your payment to be completed.', 'paid-memberships-pro' );
} else {
$message = __( 'We are waiting for your payment to be completed. Your membership will be activated once the payment has been confirmed.', 'paid-memberships-pro' );
}
?>
<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_message pmpro_alert' ) ); ?>"><?php echo esc_html( $message ); ?></div>
<?php
}
add_action( 'pmpro_membership_account_after_level_card_content', 'pmpro_account_pending_order_message' );

/**
* Add a link to view the pending order to the level card actions on the Membership Account page.
*
* If the card is already showing an "Update Billing Information" link, members can complete
* their payment there instead, so the order link is not added.
*
* @since TBD
*
* @param array $pmpro_member_action_links Member action links.
* @param int $level_id The ID of the membership level.
* @return array Member action links.
*/
function pmpro_account_pending_order_action_links( $pmpro_member_action_links, $level_id ) {
global $current_user;

// Check for a pending order for this user and level.
$pending_order = pmpro_get_pending_order_for_user_level( $current_user->ID, $level_id );
if ( empty( $pending_order ) ) {
return $pmpro_member_action_links;
}

// If we are already showing an update billing link, the member can complete their payment there.
if ( isset( $pmpro_member_action_links['update-billing'] ) ) {
return $pmpro_member_action_links;
}

$invoice_url = pmpro_url( 'invoice', '?invoice=' . $pending_order->code );
if ( ! empty( $invoice_url ) ) {
$pmpro_member_action_links['view-order'] = '<span class="' . esc_attr( pmpro_get_element_class( 'pmpro_card_action' ) ) . '"><a id="pmpro_actionlink-view-order" href="' . esc_url( $invoice_url ) . '" aria-label="' . esc_attr( __( 'View Pending Order', 'paid-memberships-pro' ) ) . '">' . esc_html__( 'View Order', 'paid-memberships-pro' ) . '</a></span>';
}

return $pmpro_member_action_links;
}
add_filter( 'pmpro_member_action_links', 'pmpro_account_pending_order_action_links', 10, 2 );

/**
* Update the level restrictions for a post.
*
Expand Down
86 changes: 83 additions & 3 deletions shortcodes/pmpro_account.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,29 @@ function pmpro_shortcode_account($atts, $content=null, $code="")
<?php } ?>

<?php if ( in_array( 'membership', $sections) || in_array( 'memberships', $sections ) ) {
// Get levels that the user does not have yet but has a pending order for. These memberships are waiting on payment.
$pending_order_levels = array();
$pending_orders = MemberOrder::get_orders(
array(
'user_id' => $current_user->ID,
'status' => 'pending',
)
);
$mylevel_ids = empty( $mylevels ) ? array() : wp_list_pluck( $mylevels, 'id' );
foreach ( $pending_orders as $pending_order ) {
// Skip if the user has this level or if we already found a pending order for it.
if ( in_array( $pending_order->membership_id, $mylevel_ids ) || isset( $pending_order_levels[ $pending_order->membership_id ] ) ) {
continue;
}
// Skip if this is not the user's most recent order for the level. A newer order in another status means the pending order is stale.
if ( empty( pmpro_get_pending_order_for_user_level( $current_user->ID, $pending_order->membership_id ) ) ) {
continue;
}
$pending_order_level = pmpro_getLevel( $pending_order->membership_id );
if ( ! empty( $pending_order_level ) ) {
$pending_order_levels[ $pending_order->membership_id ] = $pending_order_level;
}
}
?>
<section id="pmpro_account-membership" class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_section', 'pmpro_account-membership' ) ); ?>">
<?php
Expand All @@ -151,8 +174,8 @@ function pmpro_shortcode_account($atts, $content=null, $code="")
}
?>
<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_section_content' ) ); ?>">
<?php if ( empty( $mylevels ) ) {
<?php if ( empty( $mylevels ) && empty( $pending_order_levels ) ) {

?>
<div id="pmpro_account-membership-none" class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card' ) ); ?>">
<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card_content' ) ); ?>">
Expand All @@ -171,7 +194,9 @@ function pmpro_shortcode_account($atts, $content=null, $code="")
</div> <!-- end pmpro_card_content -->
</div> <!-- end pmpro_card -->
<?php
} else {
}

if ( ! empty( $mylevels ) ) {
foreach ( $mylevels as $level ) {
?>
<div id="pmpro_account-membership-<?php echo esc_attr( $level->ID ); ?>" class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card' ) ); ?>">
Expand Down Expand Up @@ -326,6 +351,61 @@ function pmpro_shortcode_account($atts, $content=null, $code="")
</div> <!-- end pmpro_card -->
<?php } ?>
<?php } ?>

<?php
// Show a card for each level that the user has a pending order for but does not have yet.
foreach ( $pending_order_levels as $pending_order_level ) {
?>
<div id="pmpro_account-membership-pending-<?php echo esc_attr( $pending_order_level->id ); ?>" class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card' ) ); ?>">

<h3 class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card_title pmpro_font-large' ) ); ?>"><?php echo esc_html( $pending_order_level->name ); ?></h3>

<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card_content' ) ); ?>">
<?php
/** This action is documented in shortcodes/pmpro_account.php */
do_action( 'pmpro_membership_account_after_level_card_content', $pending_order_level );
?>
</div> <!-- end pmpro_card_content -->

<div class="<?php echo esc_attr( pmpro_get_element_class( 'pmpro_card_actions' ) ); ?>">

<?php
/**
* Fires before the member action links.
*/
do_action( 'pmpro_member_action_links_before' );
?>

<?php
/** This filter is documented in shortcodes/pmpro_account.php */
$pmpro_member_action_links = apply_filters( 'pmpro_member_action_links', array(), $pending_order_level->id );

$allowed_html = array(
'a' => array (
'class' => array(),
'href' => array(),
'id' => array(),
'target' => array(),
'title' => array(),
'aria-label' => array(),
),
'span' => array(
'class' => array(),
),
);
echo wp_kses( implode( '<span class="' . esc_attr( pmpro_get_element_class( 'pmpro_card_action_separator' ) ) . '">' . pmpro_actions_nav_separator() . '</span>', $pmpro_member_action_links ), $allowed_html );
?>

<?php
/**
* Fires after the member action links.
*/
do_action( 'pmpro_member_action_links_after' );
?>

</div> <!-- end pmpro_card_actions -->
</div> <!-- end pmpro_card -->
<?php } ?>
</div> <!-- end pmpro_section_content -->
</section> <!-- end pmpro_account-membership -->
<?php } ?>
Expand Down