Move masthead banner settings to Template Settings sidebar - #338

Open

RachelRVasquez wants to merge 28 commits into

strangerstudios:starter-sitesfrom

RachelRVasquez:move-banner-settings

Commits on Aug 18, 2026

registering post meta and creating new functions to hide banner/breadcrumbs - we'll need this for the editor JS
RachelRVasquez
committed
4e7b191
added settings in editor JS, still testing
RachelRVasquez
committed
83a847f
Template setting toggles seem to be working, updated functions that render masthead and breadcrumbs to expect legacy or true/false values, removed fields from the sidebar/metabox, still testing
RachelRVasquez
committed
4cca8dc
starting to remove stuff we don't need while testing
RachelRVasquez
committed
9587e47
tweaked the conditional in memberlite_should_masthead_render because an empty string on a page for the banner post meta is not treated the same on a post, empty on a post means show banner, empty o…
RachelRVasquez
committed
ed7f77d
added new setting to align content in the mastheader banner, should apply to breadcrumbs, page title, and description. Needs more testing
RachelRVasquez
committed
a1666b8
testing text alignment with centered text, needs adjusting
RachelRVasquez
committed
d26b033
started to re-factor the banner a bit to remove banner right and position the icon so we can center it, not going well, revert
RachelRVasquez
committed
751f5b8
page_banners.php before I started re-arranging things
RachelRVasquez
committed
28102f9
commit progress before switching branches
RachelRVasquez
committed
a18e7cb
getting text align center to work in the masthead with the icon required some extra conditionals, still testing
RachelRVasquez
committed
55efb88
updated conditional in page_banners.php that checks whether icon exists, there's a 'blank' value when no icon is selected so we should consider that, not just 'empty'
RachelRVasquez
committed
1aa5750
moved masthead styles that was in the _shortcodes.scss file to either _masthead.scss or _pages.scss. Testing and tweaking as I compare desktop and mobile.
RachelRVasquez
committed
4be0b4b
tweak helper text in metabox so it also mentions breadcrumbs
RachelRVasquez
committed
79ff233
put back masthead hook that I accidentally removed, make sure the same conditional I added in memberlite_should_masthead_render() is also checked in memberlite_body_classes()
RachelRVasquez
committed
00899ca
formatting
RachelRVasquez
committed
9691cd1
more formatting/minor tweaks
RachelRVasquez
committed
4d72238
newline put back
RachelRVasquez
committed
ecb1bf5
started re-implementing for classic editor support, but pausing to review w/ dev team
RachelRVasquez
committed
6386211
formatting adjustments
RachelRVasquez
committed
c69c5de
add back in page banner metabox JS that was removed to support classic editor
RachelRVasquez
committed
4bf1a11
formatting adjustments
RachelRVasquez
committed
e485b6a
put back old post meta fetch for breadcrumbs, we'll need it for classic support

Scriptorium
authored and
RachelRVasquez
committed
40bcda9
remove unintentional formatting

Scriptorium
authored and
RachelRVasquez
committed
85a1665
more formatting tweaks, fix in JS so settings don't hide when going from classic editor to block editor again

Scriptorium
authored and
RachelRVasquez
committed
46e4d25
fix to ternaries/comparison logic for banner and breadcrumbs in JS
RachelRVasquez
committed
dabb3ab
fix to prevent warnings from PHP 8.1 on memberlite_is_block_editor function, needs testing
RachelRVasquez
committed
c97bdf9

Commits on Aug 19, 2026

build files so branch can be tested
RachelRVasquez
committed
e3cfbcd

Navigation Menu

Uh oh!

Move masthead banner settings to Template Settings sidebar - #338

Move masthead banner settings to Template Settings sidebar#338
RachelRVasquez wants to merge 28 commits into
strangerstudios:starter-sitesfrom
RachelRVasquez:move-banner-settings

Commits on Aug 18, 2026

registering post meta and creating new functions to hide banner/breadcrumbs - we'll need this for the editor JS

added settings in editor JS, still testing

Template setting toggles seem to be working, updated functions that render masthead and breadcrumbs to expect legacy or true/false values, removed fields from the sidebar/metabox, still testing

starting to remove stuff we don't need while testing

tweaked the conditional in memberlite_should_masthead_render because an empty string on a page for the banner post meta is not treated the same on a post, empty on a post means show banner, empty o…

added new setting to align content in the mastheader banner, should apply to breadcrumbs, page title, and description. Needs more testing

testing text alignment with centered text, needs adjusting

started to re-factor the banner a bit to remove banner right and position the icon so we can center it, not going well, revert

page_banners.php before I started re-arranging things

commit progress before switching branches

getting text align center to work in the masthead with the icon required some extra conditionals, still testing

updated conditional in page_banners.php that checks whether icon exists, there's a 'blank' value when no icon is selected so we should consider that, not just 'empty'

moved masthead styles that was in the _shortcodes.scss file to either _masthead.scss or _pages.scss. Testing and tweaking as I compare desktop and mobile.

tweak helper text in metabox so it also mentions breadcrumbs

put back masthead hook that I accidentally removed, make sure the same conditional I added in memberlite_should_masthead_render() is also checked in memberlite_body_classes()

formatting

more formatting/minor tweaks

newline put back

started re-implementing for classic editor support, but pausing to review w/ dev team

formatting adjustments

add back in page banner metabox JS that was removed to support classic editor

formatting adjustments

put back old post meta fetch for breadcrumbs, we'll need it for classic support

remove unintentional formatting

more formatting tweaks, fix in JS so settings don't hide when going from classic editor to block editor again

fix to ternaries/comparison logic for banner and breadcrumbs in JS

fix to prevent warnings from PHP 8.1 on memberlite_is_block_editor function, needs testing

Commits on Aug 19, 2026

build files so branch can be tested