Repository navigation
Speed up settled stereo reverb and mixer automation tails - #2518
Draft
yeahboi233 wants to merge 1 commit into
Draft
yeahboi233 wants to merge 1 commit into
yeahboi233 wants to merge 1 commit into
Conversation
Specialize settled stereo reverb without changing sample arithmetic, and reuse the final mixer automation value after its last keyframe. Extend exact-reference coverage to damping, wet/dry automation and request/live-override boundaries. Preserve the existing workload and 4x performance threshold; record both Colab build-profile comparisons. Co-Authored-By: Codex <noreply@openai.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing 24-track audio workload spends time re-evaluating settled reverb parameters and mixer automation after its last keyframe. This isolates the audio optimizations previously carried by #2122 so they can be reviewed independently.
Changes
No rotoscope/model dependencies, project-format changes, unrelated lint fixes or desktop MIME edits. The existing benchmark workload, timing method and greater-than-4× release threshold are unchanged.
Related: #1978 independently changes the same reverb/mixer paths with a broader optimization. This draft does not depend on it; maintainers should coordinate the overlap and merge order.
Measurements and validation
The historical October 16 same-VM comparison isolated reverb specialization (both versions already had mixer tail caching): 2.426 s baseline versus 2.224/2.201/2.225 s candidate, 8.6% less mean CPU time, 4.49–4.54× realtime. This is host-specific; it is not the combined speedup of both changes.
October 19 Colab Linux comparison against unmodified main
105c09bd, Rust 1.95.0, 8 logical Xeon 2.20 GHz CPUs:dev_icon::tests::desktop_file_matches_the_packaged_fields(source unchanged from main; separately addressed by dev desktop entry: the packaged MIME types too (dev_icon test green again) #1958) and the unchanged audio performance floor (3.594 CPU seconds in the workspace run). Both baseline and candidate also fail that floor in isolated alternating runs. No lint allowances, thresholds or ignores were changed.All compilation, tests and measurements ran on Colab. No local build or test workload ran on the contributor's Mac.
Reproduction and correctness details:
crates/audio-dsp/PERFORMANCE.md.