Skip to content

Add MaterialCraft catalog migrated from its Rust translation table #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MorionTutoriales wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add MaterialCraft catalog migrated from its Rust translation table #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ATTRIBUTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,16 @@ Synced from `photocraft@7c64653` to `photocraft@2772ac1` with
## TextureCraft initial migration

The `texturecraft.tsv` catalogs for ar, de, es, fr, it, ja, ko, pt-br and zh-hans were migrated from [TextureCraft `21856d778347e13857f65c8f1107170797bd070f`](https://github.com/storytold/texturecraft/tree/21856d778347e13857f65c8f1107170797bd070f/crates/ui-egui/src/i18n), MIT OR Apache-2.0. Original wording and contributor credits remain in the upstream history. Migration tooling was AI-assisted; no new translations were authored and no additional native-speaker review was performed. Every original row was checked against the resolved app and shared catalogs. Tracked in storytold/texturecraft#419.


## MaterialCraft initial migration

`locales/ar/materialcraft.tsv` was migrated from the Arabic Rust table in
[MaterialCraft `b73facdc7b8b5ce102cd9e14d964058a15182dc0`](https://github.com/storytold/materialcraft/blob/b73facdc7b8b5ce102cd9e14d964058a15182dc0/crates/ui-egui/src/i18n/ar.rs),
MIT OR Apache-2.0. Original wording and contributor credits remain in the upstream
history. Migration tooling was AI-assisted; no new translations were authored and
no additional native-speaker review was performed. All 400 original rows were
checked against the resolved app and shared catalogs; identical shared rows were
omitted and differing app translations retained as overrides. The unmerged Hebrew
catalog/font PRs storytold/materialcraft#197 and #198 are outside this snapshot.
Tracked in storytold/materialcraft#210.
26 changes: 26 additions & 0 deletions docs/materialcraft-migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# MaterialCraft initial catalog migration

Source: `materialcraft@b73facdc7b8b5ce102cd9e14d964058a15182dc0`.
This pre-cutover main revision offers English (source text) and Arabic. The Hebrew
catalog/font work in MaterialCraft #197/#198 was not merged at export time.

From the root of this repository, with Git, Python 3 and rustc available:

```sh
python tools/export_materialcraft.py ../materialcraft --ref b73facdc7b8b5ce102cd9e14d964058a15182dc0
python tools/export_materialcraft.py ../materialcraft --ref b73facdc7b8b5ce102cd9e14d964058a15182dc0 --check
python -m unittest discover -s tools
cargo test --workspace
```

The export compiles the original Rust table so escaped and raw strings are decoded
by Rust itself. Existing shared rows are reused only when the translation matches
exactly; differing wording stays in materialcraft.tsv. `--check` writes nothing and
compares every original translation with the resolved app/shared catalogs.
English needs no catalog, and no missing translations are invented.

This is the catalog prerequisite for storytold/materialcraft#210. MaterialCraft's
runtime cutover must pin this PR's actual upstream merge commit after acceptance,
record the translation source in its own ATTRIBUTION.md, and rerun parity against
current main. Include any locale work merged meanwhile before removing Rust tables.
The catalog PR does not close the application issue or change MaterialCraft code.
Loading
Loading