Keep SQLx codegen credentials out of process arguments - #1909
Draft
matthewpenkala wants to merge 1 commit into
Draft
Keep SQLx codegen credentials out of process arguments#1909matthewpenkala wants to merge 1 commit into
matthewpenkala wants to merge 1 commit into
Conversation
👷 Deploy request for artcraft-webapp pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for artcraft-dashboard canceled.
|
✅ Deploy Preview for storyteller-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--database-urlWhy
The previous helper could expose a credential-bearing MySQL URL through shell trace output and the
cargo sqlxprocess arguments. The revised flow keeps that value out of logs and argv while preserving SQLite and MySQL cache generation semantics.Validation
bash -n script/rust/sqlx_codegen_database.shpassedDATABASE_URLgit diff --checkpassedA live MySQL cache regeneration was not run because it requires a configured development database; the change does not modify query metadata or application runtime code.