Skip to content

Guard desktop version synchronization - #1905

Open
matthewpenkala wants to merge 1 commit into
storytold:mainfrom
matthewpenkala:contrib/validate-desktop-version-sync
Open

Guard desktop version synchronization#1905
matthewpenkala wants to merge 1 commit into
storytold:mainfrom
matthewpenkala:contrib/validate-desktop-version-sync

Conversation

@matthewpenkala

Copy link
Copy Markdown

What changed

  • Added a desktop unit test that reads both Tauri bundle configurations.
  • Fails when either configured bundle version differs from ARTCRAFT_VERSION.

Why

The desktop runtime version and the macOS bundle version are maintained in separate files. A partial version bump can therefore produce a bundle whose metadata disagrees with the version reported by the running application.

Impact

Release/version bumps now fail during the existing Rust test suite if the runtime, general Tauri configuration, and macOS Tauri configuration are not synchronized. Runtime behavior is unchanged.

Validation

  • cargo test -p artcraft version -- --nocapture (4 passed, including the new guard)
  • rustfmt --check crates/desktop/artcraft/src/version.rs
  • git diff --check
  • CodeRabbit CLI review: 0 findings
  • Gitleaks commit-range scan: no findings

Fail a desktop unit test when the runtime version diverges from either Tauri bundle configuration.
@netlify

netlify Bot commented Aug 16, 2026

Copy link
Copy Markdown

👷 Deploy request for artcraft-webapp pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 000d01c

@netlify

netlify Bot commented Aug 16, 2026

Copy link
Copy Markdown

Deploy Preview for storyteller-docs ready!

Name Link
🔨 Latest commit 000d01c
🔍 Latest deploy log https://app.netlify.com/projects/storyteller-docs/deploys/6a814b91f1aafb00082196f2
😎 Deploy Preview https://deploy-preview-1905--storyteller-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 16, 2026

Copy link
Copy Markdown

Deploy Preview for artcraft-dashboard canceled.

Name Link
🔨 Latest commit 000d01c
🔍 Latest deploy log https://app.netlify.com/projects/artcraft-dashboard/deploys/6a814b91a816d000089e1824

@matthewpenkala
matthewpenkala marked this pull request as ready for review August 17, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant