Guard desktop version synchronization - #1905
Open
matthewpenkala wants to merge 1 commit into
Open
Conversation
Fail a desktop unit test when the runtime version diverges from either Tauri bundle configuration.
👷 Deploy request for artcraft-webapp pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for storyteller-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for artcraft-dashboard canceled.
|
matthewpenkala
marked this pull request as ready for review
August 17, 2026 01:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ARTCRAFT_VERSION.Why
The desktop runtime version and the macOS bundle version are maintained in separate files. A partial version bump can therefore produce a bundle whose metadata disagrees with the version reported by the running application.
Impact
Release/version bumps now fail during the existing Rust test suite if the runtime, general Tauri configuration, and macOS Tauri configuration are not synchronized. Runtime behavior is unchanged.
Validation
cargo test -p artcraft version -- --nocapture(4 passed, including the new guard)rustfmt --check crates/desktop/artcraft/src/version.rsgit diff --check