You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
scripts: use [[ for bash tests (SonarCloud S7688) - #111
Behaviour-preserving: [[ ]] in place of [ ] for bash tests (SonarCloud shell:S7688). Every script has a bash shebang; no test uses -a/-o, escaped parentheses or an unquoted pattern on the right of =. bash -n passes on each script; the rest is left to CI.
scripts/build-web.sh (3)
Summary by CodeRabbit
Chores
Updated build-script checks. Build outputs and behavior remain unchanged; there are no user-facing changes in this release.
Behaviour-preserving: `[[ ]]` in place of `[ ]` for bash tests (SonarCloud shell:S7688). Every script has a bash shebang; no test uses `-a`/`-o`, escaped parentheses or an unquoted pattern on the right of `=`. `bash -n` passes on each script; the rest is left to CI.
- `scripts/build-web.sh` (3)
No actionable comments were generated in the recent review.
Walkthrough
The web build script now uses Bash [[ ... ]] conditionals for wasm-bindgen version checks and for selecting the output directory when PROFILE is dev. The compared values and outcomes remain unchanged.
Changes: Web Build Script
Layer / File(s)
Summary
Version and profile conditionals scripts/build-web.sh
The version checks and dev profile check now use [[ ... ]]. Error handling and the selected directory remain unchanged.
The conditional updates appear behavior-preserving; no merge-blocking risk is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the change: using Bash [[ ]] tests in scripts.
Description check
The description explains the change and reports bash -n verification, with other checks left to CI. It omits the roadmap item and the template checklist, but is otherwise informative.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5393fe10-7d67-460b-862c-f4793bc869ab
Commits
Reviewing files that changed from the base of the PR and between f696d79 and 8a46c2b.
Files selected for processing: 1
scripts/build-web.sh
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour-preserving:
[[ ]]in place of[ ]for bash tests (SonarCloud shell:S7688). Every script has a bash shebang; no test uses-a/-o, escaped parentheses or an unquoted pattern on the right of=.bash -npasses on each script; the rest is left to CI.scripts/build-web.sh(3)Summary by CodeRabbit