Update Import transaction's UI - #2149
Open
jeesunikim wants to merge 5 commits into
Open
Conversation
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
jeesunikim
force-pushed
the
update-multisig-sign-view-signatures
branch
from
August 6, 2026 06:01
3705696 to
6fe3e40
Compare
|
Something went wrong with PR preview build please check |
|
Preview is available here: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates transaction import/sign/submit UI to expose signatures, decoded XDR, and verification details while improving stale-state handling.
Changes:
- Adds signature context and JSON/XDR views.
- Adjusts multisig routing and messaging.
- Adds regression tests and footer layering fixes.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/signStepContent.test.ts |
Updates signed-result assertions. |
tests/e2e/importMultisigSubmit.test.ts |
Tests multisig submission routing. |
tests/e2e/buildFlowResetOnEdit.test.ts |
Tests stale-signature reset. |
src/styles/globals.scss |
Raises submit dropdown layering. |
src/helpers/checkRequiredSignatures.ts |
Revises offline completeness semantics. |
src/constants/networkLimits.ts |
Refreshes generated limits. |
src/components/TransactionFlowFooter/styles.scss |
Changes footer stacking. |
src/app/(sidebar)/transaction/styles.scss |
Removes legacy XDR styles. |
src/app/(sidebar)/transaction/import/page.tsx |
Adds signature context and submission fallback. |
src/app/(sidebar)/transaction/import/components/SignStepSignatureContext.tsx |
Adds signature-status panel. |
src/app/(sidebar)/transaction/import/components/ImportStepContent.tsx |
Simplifies import messaging. |
src/app/(sidebar)/transaction/components/SubmitStepContent.tsx |
Adds decoded transaction verification view. |
src/app/(sidebar)/transaction/components/SignStepContent.tsx |
Adds hash and JSON/XDR display. |
src/app/(sidebar)/transaction/components/Signatures.tsx |
Revises multisig terminology. |
src/app/(sidebar)/transaction/build/page.tsx |
Resets stale downstream state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const xdrJsonDecoded = decodeXdr({ | ||
| xdrType: "TransactionEnvelope", | ||
| xdrBlob: xdrToSign, |
Comment on lines
+165
to
+169
| signatureContext={ | ||
| <SignStepSignatureContext | ||
| xdr={sign.signedXdr || xdrToSign} | ||
| parsedTxType={importState?.parsedTxType} | ||
| /> |
| @@ -112,27 +112,6 @@ | |||
| } | |||
|
|
|||
| .SignStepContent { | |||
| "1393243355", | ||
| "1393569399", | ||
| "1393841599" | ||
| "1532250798", |
| min-height: pxToRem(80px); | ||
| background: var(--sds-clr-gray-02); | ||
| border-top: 1px solid var(--sds-clr-gray-06); | ||
| z-index: 4; |
Comment on lines
+592
to
+596
| <PrettyJsonTransaction | ||
| json={xdrJson.jsonObject} | ||
| xdr={xdrBlob} | ||
| isCodeWrapped={true} | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs more design feedback, especially around how to show existing Signatures on "Sign transaction" step
TX samples:
AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAAAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAA=AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAEAAAAAeH8YX2LLiZESynVxH8gRYbkGo9kp9WvTIKpupYBaGOwAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAGAWhjsAAAAQH33HKhPjIpWCuTTg0UwM2za+/cipMaDdrFliHBTmRcNRck0XW3Y5AYY4xu2+u/cUEzShd+1V2b7sRZdO8adGwg=AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFwAAAAAAAAAAAAAAAQAAAAAAAAABAAAAACHl1hdsb68IKFCwYxh+DyTYAFNPPQYeXIdl3VD5t/10AAAAAAAAAAAC+vCAAAAAAAAAAAGAWhjsAAAAQHj3NcCOYERqouBvL0Uv3rQ91qNkxi0H28W9g2d8MA4pRAjzU9q1v3mDsiA3EJMaxMhyy4JISzC8OXkqBiqNJQI=AAAAAgAAAADSBFf5wA+BWEc1jDmwvbVupg1OrohBSRvHtEUG0FmTSwAAAGQAJoazAAAAFgAAAAAAAAAAAAAAAQAAAAEAAAAAeH8YX2LLiZESynVxH8gRYbkGo9kp9WvTIKpupYBaGOwAAAABAAAAALeAVmIAOom1tFe0PE2ZHWOn+hSTZuYY136c6XpoWKBVAAAAAAAAAAAC+vCAAAAAAAAAAAKAWhjsAAAAQH33HKhPjIpWCuTTg0UwM2za+/cipMaDdrFliHBTmRcNRck0XW3Y5AYY4xu2+u/cUEzShd+1V2b7sRZdO8adGwjQWZNLAAAAQJ+YFFwUakiYWFhB2jKpXcLRTx0cbhni+6in7ui/vsZ037XGCUq9nm2yjNSamzO00qEvkGoKpAEKdpSTnakIDwM=(skips to submit)<Signatures/>in sign step:**Screenshots: