Skip to content

feat(ci): trigger tests on release PRs via GitHub App toke - #961

Open
JiahuiWho wants to merge 1 commit into
mainfrom
ci/release-workflow-app-token
Open

feat(ci): trigger tests on release PRs via GitHub App toke#961
JiahuiWho wants to merge 1 commit into
mainfrom
ci/release-workflow-app-token

Conversation

@JiahuiWho

@JiahuiWho JiahuiWho commented Jul 30, 2026

Copy link
Copy Markdown

What

  1. This closes Consume Release GitHub App token in new-release.yml so release PRs trigger CI #882: Wires the pre-provisioned Freighter Mobile Release GitHub App into new-release.yml, in three places.
  2. Also removes version branches (v*.*.*) from the push trigger of test.yml, ios-e2e.yml and android-e2e.yml. They remain in the pull_request trigger.

Why

  1. Events created with the default GITHUB_TOKEN don't trigger other workflows, so the release and bump-version PRs opened by new-release.yml never started test.yml, ios-e2e.yml or android-e2e.yml.
  2. The trigger change avoids the flip side of the fix. Once pushes carry the App token, a version branch fires both a push run and a pull_request run for the same commit. GitHub treats them as unrelated events and doesn't dedupe.

Note: the ops ticket specifies RELEASE_APP_ID as a repository variable, but it was provisioned as a secret, so this uses secrets.RELEASE_APP_ID.

Testing

Tested by dispatching this branch's new-release.yml against tag v1.20.27 (run): the App token minted, auto-triggered tests:

Test 30562543177
iOS E2E Tests 30562539889
Android E2E Tests 30562542302

Known limitations

  • Creating the release branch still fires a full CI round (Test + both e2e) on a commit identical to main
  • The push-trigger change can't be verified before merge

Checklist

PR structure

  • This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
  • This PR has reasonably narrow scope (break it down into smaller PRs if not).
  • This PR includes relevant before and after screenshots/videos highlighting these changes.
  • I took the time to review my own PR.

Testing

  • These changes have been tested and confirmed to work as intended on Android.
  • These changes have been tested and confirmed to work as intended on iOS.
  • These changes have been tested and confirmed to work as intended on small iOS screens.
  • These changes have been tested and confirmed to work as intended on small Android screens.
  • I have tried to break these changes while extensively testing them.
  • This PR adds tests for the new functionality or fixes.

Release

  • This is not a breaking change.
  • This PR updates existing JSDocs when applicable.
  • This PR adds JSDocs to new functionalities.
  • I've checked with the product team if we should add metrics to these changes.
  • I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

@github-actions

Copy link
Copy Markdown
Contributor

iOS Simulator preview build is ready: https://github.com/stellar/freighter-mobile/releases/tag/untagged-b86afd863f214b6e5ae2 (SDF collaborators only — install instructions in the release description)

@JiahuiWho
JiahuiWho marked this pull request as ready for review July 30, 2026 17:05
Copilot AI review requested due to automatic review settings July 30, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Uses a GitHub App token so automated release PRs trigger CI while avoiding duplicate version-branch runs.

Changes:

  • Mints and persists the release automation token for pushes and PR creation.
  • Removes version branches from push triggers while retaining PR triggers.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/new-release.yml Uses the App token for checkout, pushes, and PR creation.
.github/workflows/test.yml Excludes version branches from push-triggered tests.
.github/workflows/ios-e2e.yml Excludes version branches from push-triggered iOS E2E.
.github/workflows/android-e2e.yml Excludes version branches from push-triggered Android E2E.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JiahuiWho
JiahuiWho requested review from CassioMG and piyalbasu August 5, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consume Release GitHub App token in new-release.yml so release PRs trigger CI

2 participants