feat(ci): trigger tests on release PRs via GitHub App toke - #961
Open
JiahuiWho wants to merge 1 commit into
Open
feat(ci): trigger tests on release PRs via GitHub App toke#961JiahuiWho wants to merge 1 commit into
JiahuiWho wants to merge 1 commit into
Conversation
Contributor
|
iOS Simulator preview build is ready: https://github.com/stellar/freighter-mobile/releases/tag/untagged-b86afd863f214b6e5ae2 (SDF collaborators only — install instructions in the release description) |
Contributor
There was a problem hiding this comment.
Pull request overview
Uses a GitHub App token so automated release PRs trigger CI while avoiding duplicate version-branch runs.
Changes:
- Mints and persists the release automation token for pushes and PR creation.
- Removes version branches from push triggers while retaining PR triggers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/new-release.yml |
Uses the App token for checkout, pushes, and PR creation. |
.github/workflows/test.yml |
Excludes version branches from push-triggered tests. |
.github/workflows/ios-e2e.yml |
Excludes version branches from push-triggered iOS E2E. |
.github/workflows/android-e2e.yml |
Excludes version branches from push-triggered Android E2E. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
new-release.yml, in three places.v*.*.*) from the push trigger oftest.yml,ios-e2e.ymlandandroid-e2e.yml. They remain in thepull_requesttrigger.Why
GITHUB_TOKENdon't trigger other workflows, so the release and bump-version PRs opened bynew-release.ymlnever startedtest.yml,ios-e2e.ymlorandroid-e2e.yml.pushrun and apull_requestrun for the same commit. GitHub treats them as unrelated events and doesn't dedupe.Note: the ops ticket specifies
RELEASE_APP_IDas a repository variable, but it was provisioned as a secret, so this usessecrets.RELEASE_APP_ID.Testing
Tested by dispatching this branch's
new-release.ymlagainst tagv1.20.27(run): the App token minted, auto-triggered tests:Test 30562543177
iOS E2E Tests 30562539889
Android E2E Tests 30562542302
Known limitations
releasebranch still fires a full CI round (Test + both e2e) on a commit identical tomainChecklist
PR structure
Testing
Release