[vm2] fix delayed-field in-place materialization for from-state base - #4842
Draft
jackzhhuang wants to merge 3 commits into
Draft
[vm2] fix delayed-field in-place materialization for from-state base#4842jackzhhuang wants to merge 3 commits into
jackzhhuang wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InPlaceDelayedFieldChangematerialization when base bytes are not yet cached.tests_delayed_from_state.rs).Root Cause
materialize_in_place_changeassumed base bytes always existed inDelayedFieldCache.In delayed-only from-state scenarios, cache can be empty, causing:
Missing cached base value for delayed field exchange.Fix
StateView, insert into cache, then materialize.StateKeyas sequential materialization candidates to preserve ordering guarantees.Validation
cargo fmtcargo checkcargo fmt -- --checkcargo clippy --all-targets -- -Aclippy::doc_lazy_continuationcargo test -p starcoin-vm-runtime delayed_only_from_state_without_cached_base_should_materialize -- --nocapturecargo test -p starcoin-vm-runtime delayed_only_dependency_materialization_matches_legacy_all_seq -- --nocapture