Skip to content

ROX-36447: Migrate from clair-scan to roxctl-scan - #3695

Open
vickeybrown wants to merge 1 commit into
masterfrom
migrate-to-roxctl-scan
Open

ROX-36447: Migrate from clair-scan to roxctl-scan#3695
vickeybrown wants to merge 1 commit into
masterfrom
migrate-to-roxctl-scan

Conversation

@vickeybrown

Copy link
Copy Markdown

Replace clair-scan task with roxctl-scan to provide better security coverage as per Konflux Integration Service Team migration plan.

Changes:

  • Updated task name from clair-scan to roxctl-scan
  • Updated bundle reference to task-roxctl-scan:0.1
  • Removed matrix configuration as roxctl-scan handles multi-arch natively

@vickeybrown
vickeybrown requested review from a team and rhacs-bot as code owners August 25, 2026 16:15
@rhacs-bot
rhacs-bot requested a review from a team August 25, 2026 16:16
@vickeybrown vickeybrown changed the title Migrate from clair-scan to roxctl-scan ROX-36447: Migrate from clair-scan to roxctl-scan Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 677397c3-1bff-46b4-899c-6b60a8ebd779

📥 Commits

Reviewing files that changed from the base of the PR and between 542c65b and 79ed2b9.

📒 Files selected for processing (1)
  • .tekton/scanner-component-pipeline.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated image scanning to run once against the combined multi-platform image digest and URL, improving scan consistency across supported platforms.
    • Added Clair scanning for multi-platform images when security checks are enabled.

Walkthrough

The Tekton pipeline removes the roxctl-scan platform matrix. It runs one scan for the multi-platform image and conditionally runs a pinned Clair scan using the image index digest and URL.

Changes

Scanner pipeline execution

Layer / File(s) Summary
Use one multi-platform scan
.tekton/scanner-component-pipeline.yaml
The roxctl-scan task runs once instead of once per build platform.
Add conditional Clair scanning
.tekton/scanner-component-pipeline.yaml
The pipeline adds a pinned clair-scan task that uses the built image index digest and URL. The task is skipped when skip-checks is true.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 79ed2

This PR updates the scanner pipeline to use roxctl-scan and removes the obsolete matrix configuration; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: rhacs-bot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the migration from clair-scan to roxctl-scan, including the bundle update and removal of matrix configuration.
Title check ✅ Passed The title clearly identifies the main change: migrating from clair-scan to roxctl-scan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-to-roxctl-scan

Comment @coderabbitai help to get the list of available commands.

@vickeybrown

Copy link
Copy Markdown
Author

/retest

Replace clair-scan task with roxctl-scan to provide better security
coverage as per Konflux Integration Service Team migration plan.

Changes:
- Updated task name from clair-scan to roxctl-scan
- Updated bundle reference to task-roxctl-scan:0.1
- Removed matrix configuration as roxctl-scan handles multi-arch natively

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

# Conflicts:
#	.tekton/scanner-component-pipeline.yaml
@vickeybrown
vickeybrown force-pushed the migrate-to-roxctl-scan branch from 542c65b to 79ed2b9 Compare August 27, 2026 14:32
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

@vickeybrown: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 79ed2b9 link false /test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant