Skip to content

fix: persist expanded text state of an item with query params #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Soxasora wants to merge 3 commits into
base: master
Choose a base branch
from
+33 −14
Draft

fix: persist expanded text state of an item with query params #3060

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8902b1d
persist `show full text` state of an item to query params
Soxasora Jun 10, 2026
ab2dd2e
refactor: persist expanded item state in sessionStorage
Soxasora Jun 10, 2026
3ef5782
cleanup: useSyncExternalStore is not reactive, only used to influence…
Soxasora Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions components/text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,23 @@ export function useOverflow ({ containerRef, truncated = false }) {
const router = useRouter()
// would the text overflow on the current screen size?
const [overflowing, setOverflowing] = useState(false)
// should we show the full text?
const [show, setShow] = useState(false)
const showOverflow = useCallback(() => setShow(true), [setShow])
// always show the full text if the `full` query param is set
const [show, setShow] = useState(!!router.query.full)
Comment thread
Soxasora marked this conversation as resolved.
Outdated

const showOverflow = useCallback(() => {
// save the full text state to the query param
router.replace({
pathname: router.pathname,
query: { ...router.query, full: true }
}, router.asPath, { shallow: true })
setShow(true)
}, [router])

// if we are navigating to a hash, show the full text
useEffect(() => {
setShow(router.asPath.includes('#'))
const handleRouteChange = (url, { shallow }) => {
setShow(url.includes('#'))
if (router.asPath.includes('#')) setShow(true)
const handleRouteChange = (url) => {
if (url.includes('#')) setShow(true)
Comment thread
Soxasora marked this conversation as resolved.
Outdated
}

router.events.on('hashChangeStart', handleRouteChange)
Expand Down
Loading