Fix filtered shared-netns lifecycle reconciliation - #3287
Draft
orrious wants to merge 21 commits into
Draft
Conversation
# Conflicts: # core/topology_reconcile.go # nodes/default_node_test.go # nodes/ext_container/ext_container.go # types/topo_diff.go
orrious
force-pushed
the
feature/apply-shared-netns-lifecycle
branch
from
July 18, 2026 01:30
372af31 to
aacb439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final source
feature/apply-shared-netns-lifecycle7e3f220c169e646f85e07c962e7424c630890c15orrious/containerlabValidation
sudo env HOME=/home/opc make test./core ./core/dependency_manager ./nodes ./links ./runtime/podmanTestVerifyLinks: passedmake build-with-podman: passed30-apply-filter.robotagainst exact source binary: 3 passed/usr/bin/clabrootful Robot30-apply-filter.robot: 3 passed0.0.0-next.7e3f220c, embedded commit7e3f220ccontainerlab_0.0.0-next.7e3f220c_linux_amd64.rpmb863dac2eeb12f8f48212809a8fb623d4355fad9bcaedce4cc9111f340dd30a8Live x86 validation
us-miami-1oc99-mia-btor1-private-dns-authcore0ee41d6c8c3f10.133.54.0/32,172.16.0.150/24, and default route via172.16.0.1Remaining validation
This PR remains draft. The project runbook requires a macOS/Colima functional smoke, while the active assignment explicitly restricts validation to the x86 runner and forbids Colima. Authcore itself also remained in its pre-existing
startinghealth state because its image reports a missing healthcheck file; reconciliation neither caused nor changed that condition.