Repository navigation
contract: history resolutions come from the power history - #1856
Merged
Merged
Conversation
Copy of srcfl/ftw-webapp's registry change, with contract_gen.go regenerated. #1854 serves grid, PV and battery tiles from the measured power rows at 5m and 1h alike; load stays the ledger's consumer use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
added
the
no-changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1854 (merged) serves the app's history tiles for grid, PV and battery from the measured power rows that
/api/historydraws, at 5m and 1h alike. Load stays the energy ledger's consumer use. The registry still saidsource: energy_ledgerfor 5m andsource: hourly_rollupfor 1h.What changes
resolutionsinregistry.yaml:source: power_historyfor both. No geometry changes: same tile spans, same retention. The generatedgo/protocol/contract_gen.gocomment follows (ResN5mandResN1h"come from the power_history").Paired with srcfl/ftw-webapp, where the registry is edited, and srcfl/ftw-app. Merge the three together.
Contract-pair: srcfl/ftw-webapp@fe1db8c
Checks
go generateingo/internal/appprotoandgo test ./internal/appproto/...pass.🤖 Generated with Claude Code