Repository navigation
test(site): an import ceiling and two equal batteries in the site pack - #1837
Merged
Merged
Conversation
s16 runs Charge now under a 4.5 kW hourly import ceiling with house and the car's minimum above it (#1828). s17 runs two equal batteries under Energyplan (#1814). FTW_SITE_ENGINE picks the planner for a whole run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Over 48 h Energyplan keeps both batteries for tomorrow's dearer evening and the plan's current quarter stays idle, so Core's per-battery path never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tonight's beta carries #1828 (an idle car starts on the hour's slack under the import ceiling) and #1814 (interchangeable batteries share the plan's total). The site pack had no case for either. Its house also plans with Core DP, which refuses two batteries, while a beta box plans with Energyplan.
Test-only:
go/test/site. No Core change, no changeset.What
s16-25, import ceiling (the help report behind fix(control): an idle car starts on the hour's slack under the import ceiling #1828). 25 A, house 1.3 kW, the battery held idle at its floor,POST /api/peak_import_ceiling4 500 W, Charge now 16 A. House plus the car's 4 140 W minimum is above the ceiling. Core counts the part of an hour before its first reading at the ceiling, so the case starts in an hour's first 4 minutes or waits for :56, then runs one whole clock hour and 3 minutes. Criteria:import_limitin 90 % of samples and neverfuse_limit;s17-25, two equal batteries (Rann's site behind fix(control): interchangeable batteries share the plan's total #1814). Two hybrids with 10 kWh at 74 % and 60 %, house 3 kW, no PV, Energyplan with a 6 h horizon. Energyplan puts each quarter's discharge on one battery, as on Rann's site. Over its usual 48 h it keeps both batteries for the dearest hours. Today that was Monday evening at 40–60 öre, so the current quarter stayed idle and Core's per-battery path never ran. Over 6 h the batteries hold more than the house needs, so the plan discharges now. The case still waits up to an hour for a quarter the plan discharges, then runs 15 minutes. Every 30 s it saves the plan's order for each battery inplan.jsonl. Criteria:FTW_SITE_ENGINE=core|energyplanpicks the planner for a whole run. Defaultcore, as before. Forenergyplanthe run directory linksoptimizer/native/bundle, where FTW looks for the worker. Only a run with Energyplan gets the link, so Core DP runs keep today's behaviour.phase_w(site power) and a second battery (inverter2)./api/loadpointsreadsmanual.limit_reason.Evidence
All runs: device-simulator
a3030d3, drivers219c462e, on the M5 laptop. Each Core is built from the commit named.69700f41import_limit, nonefuse_limit. Worst phase 8.5 A.0c8eaef9, before #1828import_limit. This is the help report.69700f411883582e, before #1814FTW_SITE_ENGINE=energyplan69700f4116c4ad09. 85 min in three lanes.go vet ./test/site/andgo test ./test/site/(the unit tests;TestSiteskips withoutFTW_SITE) pass.Timing: s16 runs about 65 min, longest first in its lane. Started between :04 and :56 it first waits for :56. s17 runs 17 min when the plan discharges at once, and up to 77 min when it does not.
Not here
TestSiteSimDutyOnTimeYieldsToTheImportCeilingcovers it.🤖 Generated with Claude Code