Repository navigation
feat: add Sungrow observe-only FTW pilot - #3
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b44b5ee326
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| verified_by = { "frahlg@homelab-rpi:14d" }, | ||
| verified_at = "2026-04-18", | ||
| verification_notes = "Battery control + telemetry in continuous use on homelab-rpi. Device type 0x0E0E (SH8.0RT-V112).", |
There was a problem hiding this comment.
Remove private site identity from baseline metadata
This public repo’s AGENTS.md says to never add site data, but the imported baseline now includes a verifier string with a user/host identifier and the adjacent notes name the same host. Even if the baseline is intended to stay byte-exact, publishing this operator/site identity in the repository is unnecessary for parity checks and should be redacted or moved to non-public evidence.
Useful? React with 👍 / 👎.
| mppt1_w = mppt1_w, | ||
| mppt2_w = mppt2_w, | ||
| pv_source = pv_source, -- "primary_reg" | "mppt_sum" | "zero" |
There was a problem hiding this comment.
Keep diagnostics out of PV telemetry fields
When an approved profile eventually lets this target poll, the PV DER includes mppt1_w, mppt2_w, and the string pv_source, but the repo’s runtime field contract only recognizes PV fields listed in drivers/tests/test_emit_fields.py / spec/host-api.md (w, rated power, MPPT V/A, temp, lifetime, and limits). These diagnostics are already sent through host.emit_metric, so leaving them in host.emit("pv", ...) can cause the package target to produce telemetry the FTW runtime rejects or silently drops.
Useful? React with 👍 / 👎.
Summary
FTW baseline
Candidate evidence
Validation
Gates