feat: allow string RPC URL for provider configuration in verify and validate - #221
Open
lx3133584 wants to merge 1 commit into
Open
feat: allow string RPC URL for provider configuration in verify and validate#221lx3133584 wants to merge 1 commit into
lx3133584 wants to merge 1 commit into
Conversation
…alidate Fixes spruceid#180 Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SiweMessage.verifyandSiweMessage.validaterequire an instantiated EthersProviderobject for EIP-1271 contract wallet verification. This forces consumers to take on a direct runtime dependency on Ethers even when they only need to specify an RPC endpoint URL.Solution
VerifyOpts.providertype to acceptproviders.Provider | string.getJsonRpcProvider(url)helper inethersCompat.tsto construct aJsonRpcProvideracross ethers v5 and v6.checkContractWalletSignatureinutils.tsto automatically instantiate aJsonRpcProviderwhen a string URL is supplied.Testing
packages/siwe/lib/client.test.tsverifying that string RPC URLs are accepted and correctly instantiated as provider runners.