fix(client): skip ecrecover for non-ECDSA contract-wallet signatures - #219
Open
rome-xi wants to merge 1 commit into
Open
fix(client): skip ecrecover for non-ECDSA contract-wallet signatures#219rome-xi wants to merge 1 commit into
rome-xi wants to merge 1 commit into
Conversation
Signed-off-by: rome-xi <rome-xi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify() always ran ethers verifyMessage before the EIP-1271 fallback.
Multisig and other contract-wallet signatures are longer than a 65-byte ECDSA signature,
so ethers throws invalid raw signature length (and the catch logs it) even though
checkContractWalletSignature then succeeds.
Skip ecrecover when the signature is not 65 bytes (r||s||v) or 64 bytes (EIP-2098 compact)
and go straight to EIP-1271.
Test plan
Fixes #216