fix(client): do not log signature recovery errors to console.error - #218
Open
SnowingFox wants to merge 1 commit into
Open
fix(client): do not log signature recovery errors to console.error#218SnowingFox wants to merge 1 commit into
SnowingFox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #172. The
verify()path inpackages/siwe/lib/client.tscallsconsole.error(e)inside thetry/catchthat recovers the signer address from the signature. A library logging internally like this pollutes application output and breaks consumers with custom logging flows (e.g. JSON-formatted logs for SaaS log analysis).Change
console.error(e)call. On an unrecoverable signature (e.g. malformed),addrstaysundefinedand the existing address-match / EIP-1271 fallback path reports the verification as anINVALID_SIGNATUREfailure exactly as before — no behavior change, just no internal logging.console.errorwhile still returning a failed verification.