-
-
Notifications
You must be signed in to change notification settings - Fork 121
Add -normalize-PAM50 argument to metric extraction script to allow interpolation to PAM50 space
#5236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valosekj
wants to merge
25
commits into
master
Choose a base branch
from
jv/sct_extract_metric_normalize_pam50
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−7
Open
Add -normalize-PAM50 argument to metric extraction script to allow interpolation to PAM50 space
#5236
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f850274
Add PAM50 normalization option (a new arg '-normalize-PAM50') to `sct…
valosekj ddad85d
Add fall back to all available levels when fewer than 3 levels are pr…
valosekj 02a053f
Add tests
valosekj 66c5895
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj 587f354
improve comments and docstring
valosekj 385b763
add some extra comments to improve code readability
valosekj cd11024
clarify fallback section to all available levels
valosekj cdad227
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj e08b6c8
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
joshuacwnewton d7c8937
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj bd03cd8
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj 978d34c
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj b518834
Merge remote-tracking branch 'origin/master' into jv/sct_extract_metr…
valosekj bbf7755
Simplify `-normalize-PAM50` to a single `extract_metric()` call
valosekj 47fafc4
Remove obsolete `sct_testing` marker
valosekj a564810
Improve test_cli_sct_extract_metric
valosekj 2ad22cd
Document extract_metric-form vs compute_shape-form conversion
valosekj 42a3461
Explain that 0 and values >=49 are reserved/non-vertebral-level labels
valosekj 7f04548
Move `_build_pam50_agg_metric` from `sct_extract_metric` to `metrics_…
valosekj 6b27442
Clarify `-z` arg help text
valosekj 669672d
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj dba8c25
Update docstring of `interpolate_metrics`
valosekj d51afda
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj 14d0849
Simplify scale_mean computation in interpolate_metrics
valosekj 350e8a4
Merge branch 'master' into jv/sct_extract_metric_normalize_pam50
valosekj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.