Take FlashWithMutex without the CMP abstraction - #125
Merged
Conversation
Upstream tlaplus/Examples#226 moves the Murphi model's CMP Other-node abstraction into a separate FlashWithMutexCMP.tla. That abstraction exists so that model checking one node count stands for all of them; TLAPS proves the protocol for every constant value, so its ABS_* rules, the Env_o conjunct in every UNCHANGED list, and the Other-widened NodeU were only ever noise in a proof target -- and noise interleaved with the protocol's own actions. The benchmark tracks the protocol alone. All 17 theorem statements are unchanged, so the targets are the same; the regenerated model drops 268 lines and nine Defs files lose the ABS_* actions and the fairness conjuncts that existed to keep them live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream tlaplus/Examples#226 moves the Murphi model's CMP Other-node abstraction into a separate FlashWithMutexCMP.tla. That abstraction exists so that model checking one node count stands for all of them; TLAPS proves the protocol for every constant value, so its ABS_* rules, the Env_o conjunct in every UNCHANGED list, and the Other-widened NodeU were only ever noise in a proof target -- and noise interleaved with the protocol's own actions.
The benchmark tracks the protocol alone. All 17 theorem statements are unchanged, so the targets are the same; the regenerated model drops 268 lines and nine Defs files lose the ABS_* actions and the fairness conjuncts that existed to keep them live.